Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2055803002: [wasm] Fix CFI failures due to Wasm threads. (Closed)

Created:
4 years, 6 months ago by titzer
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix CFI failures due to Wasm threads. R=ahaas@chromium.org,machenbach@chromium.org BUG= Committed: https://crrev.com/26afd571c56a4e71df7ed062393e62a263d70201 Cr-Commit-Position: refs/heads/master@{#36866}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -39 lines) Patch
M src/wasm/wasm-interpreter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-interpreter.cc View 3 chunks +12 lines, -6 lines 1 comment Download
M test/cctest/wasm/test-run-wasm-interpreter.cc View 5 chunks +26 lines, -26 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
4 years, 6 months ago (2016-06-09 13:42:08 UTC) #1
ahaas
lgtm https://codereview.chromium.org/2055803002/diff/1/src/wasm/wasm-interpreter.cc File src/wasm/wasm-interpreter.cc (right): https://codereview.chromium.org/2055803002/diff/1/src/wasm/wasm-interpreter.cc#newcode1702 src/wasm/wasm-interpreter.cc:1702: WasmInterpreter::~WasmInterpreter() { internals_->Delete(); } I wonder if it ...
4 years, 6 months ago (2016-06-09 14:07:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055803002/1
4 years, 6 months ago (2016-06-09 14:09:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 14:22:14 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/26afd571c56a4e71df7ed062393e62a263d70201 Cr-Commit-Position: refs/heads/master@{#36866}
4 years, 6 months ago (2016-06-09 14:24:01 UTC) #7
Michael Achenbach
4 years, 6 months ago (2016-06-09 15:25:14 UTC) #8
Message was sent while issue was closed. 
Greenified \o/ thanks!

Powered by Google App Engine
This is Rietveld 408576698