Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2055793002: Revert of [ic] Don't pollute per-map code cache with CompareIC stubs. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [ic] Don't pollute per-map code cache with CompareIC stubs. (patchset #1 id:20001 of https://codereview.chromium.org/2053583002/ ) Reason for revert: [Sheriff] Speculative revert. Tail call test timing out: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10014 Original issue's description: > [ic] Don't pollute per-map code cache with CompareIC stubs. > > Given that > 1) because of code flags mismatch we are not able to fetch any CompareIC stub that was put into the cache (we put MONOMORPHIC stubs but query only UNINITIALIZED ones), > 2) it was already broken for a couple of years, > 3) we will not need to cache any stub once CompareIC becomes vector-based. > > Committed: https://crrev.com/172ddf4250e5c4b7510ce352631fb9f8eb291940 > Cr-Commit-Position: refs/heads/master@{#36854} TBR=verwaest@chromium.org,jkummerow@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/1d2ee8fd10adbfa5d213462c46181fa1ca899a61 Cr-Commit-Position: refs/heads/master@{#36856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M src/code-stubs.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Achenbach
Created Revert of [ic] Don't pollute per-map code cache with CompareIC stubs.
4 years, 6 months ago (2016-06-09 12:24:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055793002/1
4 years, 6 months ago (2016-06-09 12:24:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 12:24:43 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1d2ee8fd10adbfa5d213462c46181fa1ca899a61 Cr-Commit-Position: refs/heads/master@{#36856}
4 years, 6 months ago (2016-06-09 12:27:01 UTC) #7
Michael Achenbach
4 years, 6 months ago (2016-06-09 12:30:09 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2051823002/ by machenbach@chromium.org.

The reason for reverting is: Not the cause....

Powered by Google App Engine
This is Rietveld 408576698