Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2055703002: S390: [gn] define V8_TARGET_ARCH_S390_LE_SIM for s390 sim build (Closed)

Created:
4 years, 6 months ago by john.yan
Modified:
4 years, 6 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [gn] define V8_TARGET_ARCH_S390_LE_SIM for s390 sim build R=machenbach@chromium.org BUG= Committed: https://crrev.com/280b8382553c3fedb51f5e1490dbf69dfea93188 Cr-Commit-Position: refs/heads/master@{#36865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M BUILD.gn View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 6 months ago (2016-06-09 02:50:34 UTC) #1
Michael Achenbach
lgtm
4 years, 6 months ago (2016-06-09 06:42:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055703002/1
4 years, 6 months ago (2016-06-09 13:42:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 14:19:42 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 14:21:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/280b8382553c3fedb51f5e1490dbf69dfea93188
Cr-Commit-Position: refs/heads/master@{#36865}

Powered by Google App Engine
This is Rietveld 408576698