Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4836)

Unified Diff: chrome/renderer/autofill/autofill_renderer_browsertest.cc

Issue 2055693002: Add delay to didAssociateFormControlsTimer so it doesn't fire too frequently (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/autofill_renderer_browsertest.cc
diff --git a/chrome/renderer/autofill/autofill_renderer_browsertest.cc b/chrome/renderer/autofill/autofill_renderer_browsertest.cc
index 5e54b6b0b979a58373cdafd67f9d876f3fa59467..038c1f4f3dbc7021d7509f911dc231ea90dbe4b9 100644
--- a/chrome/renderer/autofill/autofill_renderer_browsertest.cc
+++ b/chrome/renderer/autofill/autofill_renderer_browsertest.cc
@@ -136,6 +136,7 @@ TEST_F(AutofillRendererTest, SendForms) {
"document.body.appendChild(newForm);");
msg_loop_.RunUntilIdle();
+ WaitForAutofillDidAssociateFormControl();
message = render_thread_->sink().GetFirstMessageMatching(
AutofillHostMsg_FormsSeen::ID);
ASSERT_NE(nullptr, message);
@@ -214,8 +215,10 @@ TEST_F(AutofillRendererTest, DynamicallyAddedUnownedFormElements) {
ExecuteJavaScriptForTests("AddFields()");
msg_loop_.RunUntilIdle();
+ WaitForAutofillDidAssociateFormControl();
message = render_thread_->sink().GetFirstMessageMatching(
AutofillHostMsg_FormsSeen::ID);
+
ASSERT_NE(nullptr, message);
AutofillHostMsg_FormsSeen::Read(message, &params);
forms = std::get<0>(params);

Powered by Google App Engine
This is Rietveld 408576698