Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2055693002: Add delay to didAssociateFormControlsTimer so it doesn't fire too frequently (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 5693 matching lines...) Expand 10 before | Expand all | Expand 10 after
5704 m_templateDocument->m_templateDocumentHost = this; // balanced in dtor. 5704 m_templateDocument->m_templateDocumentHost = this; // balanced in dtor.
5705 5705
5706 return *m_templateDocument.get(); 5706 return *m_templateDocument.get();
5707 } 5707 }
5708 5708
5709 void Document::didAssociateFormControl(Element* element) 5709 void Document::didAssociateFormControl(Element* element)
5710 { 5710 {
5711 if (!frame() || !frame()->page()) 5711 if (!frame() || !frame()->page())
5712 return; 5712 return;
5713 m_associatedFormControls.add(element); 5713 m_associatedFormControls.add(element);
5714 // We add a slight delay because this could be called rapidly.
5714 if (!m_didAssociateFormControlsTimer.isActive()) 5715 if (!m_didAssociateFormControlsTimer.isActive())
5715 m_didAssociateFormControlsTimer.startOneShot(0, BLINK_FROM_HERE); 5716 m_didAssociateFormControlsTimer.startOneShot(0.3, BLINK_FROM_HERE);
5716 } 5717 }
5717 5718
5718 void Document::removeFormAssociation(Element* element) 5719 void Document::removeFormAssociation(Element* element)
5719 { 5720 {
5720 auto it = m_associatedFormControls.find(element); 5721 auto it = m_associatedFormControls.find(element);
5721 if (it == m_associatedFormControls.end()) 5722 if (it == m_associatedFormControls.end())
5722 return; 5723 return;
5723 m_associatedFormControls.remove(it); 5724 m_associatedFormControls.remove(it);
5724 if (m_associatedFormControls.isEmpty()) 5725 if (m_associatedFormControls.isEmpty())
5725 m_didAssociateFormControlsTimer.stop(); 5726 m_didAssociateFormControlsTimer.stop();
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
6018 } 6019 }
6019 6020
6020 void showLiveDocumentInstances() 6021 void showLiveDocumentInstances()
6021 { 6022 {
6022 WeakDocumentSet& set = liveDocumentSet(); 6023 WeakDocumentSet& set = liveDocumentSet();
6023 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 6024 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
6024 for (Document* document : set) 6025 for (Document* document : set)
6025 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().get String().utf8().data()); 6026 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().get String().utf8().data());
6026 } 6027 }
6027 #endif 6028 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698