Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2055693002: Add delay to didAssociateFormControlsTimer so it doesn't fire too frequently (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/autofill/content/renderer/autofill_agent.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 5708 matching lines...) Expand 10 before | Expand all | Expand 10 after
5719 m_templateDocument->m_templateDocumentHost = this; // balanced in dtor. 5719 m_templateDocument->m_templateDocumentHost = this; // balanced in dtor.
5720 5720
5721 return *m_templateDocument.get(); 5721 return *m_templateDocument.get();
5722 } 5722 }
5723 5723
5724 void Document::didAssociateFormControl(Element* element) 5724 void Document::didAssociateFormControl(Element* element)
5725 { 5725 {
5726 if (!frame() || !frame()->page()) 5726 if (!frame() || !frame()->page())
5727 return; 5727 return;
5728 m_associatedFormControls.add(element); 5728 m_associatedFormControls.add(element);
5729 // We add a slight delay because this could be called rapidly.
5729 if (!m_didAssociateFormControlsTimer.isActive()) 5730 if (!m_didAssociateFormControlsTimer.isActive())
5730 m_didAssociateFormControlsTimer.startOneShot(0, BLINK_FROM_HERE); 5731 m_didAssociateFormControlsTimer.startOneShot(0.3, BLINK_FROM_HERE);
5731 } 5732 }
5732 5733
5733 void Document::removeFormAssociation(Element* element) 5734 void Document::removeFormAssociation(Element* element)
5734 { 5735 {
5735 auto it = m_associatedFormControls.find(element); 5736 auto it = m_associatedFormControls.find(element);
5736 if (it == m_associatedFormControls.end()) 5737 if (it == m_associatedFormControls.end())
5737 return; 5738 return;
5738 m_associatedFormControls.remove(it); 5739 m_associatedFormControls.remove(it);
5739 if (m_associatedFormControls.isEmpty()) 5740 if (m_associatedFormControls.isEmpty())
5740 m_didAssociateFormControlsTimer.stop(); 5741 m_didAssociateFormControlsTimer.stop();
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
6033 } 6034 }
6034 6035
6035 void showLiveDocumentInstances() 6036 void showLiveDocumentInstances()
6036 { 6037 {
6037 WeakDocumentSet& set = liveDocumentSet(); 6038 WeakDocumentSet& set = liveDocumentSet();
6038 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 6039 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
6039 for (Document* document : set) 6040 for (Document* document : set)
6040 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().get String().utf8().data()); 6041 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().get String().utf8().data());
6041 } 6042 }
6042 #endif 6043 #endif
OLDNEW
« no previous file with comments | « components/autofill/content/renderer/autofill_agent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698