Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: ipc/mojo/ipc_channel_mojo_unittest.cc

Issue 2055683002: Quit the test child message loop on connection error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/mojo/ipc_channel_mojo_unittest.cc
diff --git a/ipc/mojo/ipc_channel_mojo_unittest.cc b/ipc/mojo/ipc_channel_mojo_unittest.cc
index 613b2e2611607c514809e2a296b5495835391ca9..b50c82d816c232618fe936280dafe38d0f11406c 100644
--- a/ipc/mojo/ipc_channel_mojo_unittest.cc
+++ b/ipc/mojo/ipc_channel_mojo_unittest.cc
@@ -380,12 +380,13 @@ class ListenerThatExpectsMessagePipe : public IPC::Listener {
bool OnMessageReceived(const IPC::Message& message) override {
base::PickleIterator iter(message);
HandleSendingHelper::ReadReceivedPipe(message, &iter);
- base::MessageLoop::current()->QuitWhenIdle();
ListenerThatExpectsOK::SendOK(sender_);
return true;
}
- void OnChannelError() override { NOTREACHED(); }
+ void OnChannelError() override {
+ base::MessageLoop::current()->QuitWhenIdle();
+ }
void set_sender(IPC::Sender* sender) { sender_ = sender; }
@@ -457,12 +458,14 @@ class ListenerThatExpectsMessagePipeUsingParamTrait : public IPC::Listener {
MojoClose(handle.value());
}
- base::MessageLoop::current()->QuitWhenIdle();
ListenerThatExpectsOK::SendOK(sender_);
return true;
}
- void OnChannelError() override { NOTREACHED(); }
+ void OnChannelError() override {
+ base::MessageLoop::current()->QuitWhenIdle();
+ }
+
void set_sender(IPC::Sender* sender) { sender_ = sender; }
private:
@@ -589,12 +592,13 @@ class ListenerThatExpectsFile : public IPC::Listener {
bool OnMessageReceived(const IPC::Message& message) override {
base::PickleIterator iter(message);
HandleSendingHelper::ReadReceivedFile(message, &iter);
- base::MessageLoop::current()->QuitWhenIdle();
ListenerThatExpectsOK::SendOK(sender_);
return true;
}
- void OnChannelError() override { NOTREACHED(); }
+ void OnChannelError() override {
+ base::MessageLoop::current()->QuitWhenIdle();
+ }
void set_sender(IPC::Sender* sender) { sender_ = sender; }
@@ -642,12 +646,13 @@ class ListenerThatExpectsFileAndPipe : public IPC::Listener {
base::PickleIterator iter(message);
HandleSendingHelper::ReadReceivedFile(message, &iter);
HandleSendingHelper::ReadReceivedPipe(message, &iter);
- base::MessageLoop::current()->QuitWhenIdle();
ListenerThatExpectsOK::SendOK(sender_);
return true;
}
- void OnChannelError() override { NOTREACHED(); }
+ void OnChannelError() override {
+ base::MessageLoop::current()->QuitWhenIdle();
+ }
void set_sender(IPC::Sender* sender) { sender_ = sender; }
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698