Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 2055683002: Quit the test child message loop on connection error. (Closed)

Created:
4 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Quit the test child message loop on connection error. This de-flakes ipc_mojo_unittests. The test were failing because the child message handler called QuitWhenIdle, and the the listener's error handler could be called before the loop is idled. BUG=617938 Committed: https://crrev.com/6c70caea4db31d9d131178ec55a464649a1227be Cr-Commit-Position: refs/heads/master@{#398768}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M ipc/mojo/ipc_channel_mojo_unittest.cc View 4 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Anand Mistry (off Chromium)
4 years, 6 months ago (2016-06-09 01:51:23 UTC) #2
Sam McNally
lgtm
4 years, 6 months ago (2016-06-09 02:46:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055683002/1
4 years, 6 months ago (2016-06-09 02:52:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 03:08:51 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 03:10:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c70caea4db31d9d131178ec55a464649a1227be
Cr-Commit-Position: refs/heads/master@{#398768}

Powered by Google App Engine
This is Rietveld 408576698