[Mac/GN] Add //build/config/mac/package_framework.py.

[Mac/GN] Add //build/config/mac/package_framework.py.

This moves another step performed by gyp-mac-tool into a standalone script. In
addition, support for more top-level bundle directories (e.g. Helpers, XPCServices,
etc.) is added.

BUG=616813, 604809
R=sdefresne@chromium.org

Committed: https://crrev.com/51dc7dae178061bfcc559f16d85e43f2695efacf
Cr-Commit-Position: refs/heads/master@{#398884}

[sdefresne, 2016-06-09 07:16:18]

lgtm

https://codereview.chromium.org/2055673002/diff/1/build/config/mac/package_fr...
File build/config/mac/package_framework.py (right):

https://codereview.chromium.org/2055673002/diff/1/build/config/mac/package_fr...
build/config/mac/package_framework.py:19: binary =
os.path.basename(framework).split('.')[0]
nit: os.path.splitext(os.path.basename(framework))[0]

https://codereview.chromium.org/2055673002/diff/1/build/config/mac/package_fr...
build/config/mac/package_framework.py:31: pwd = os.getcwd()
If you want to be sure to restore the current working directory before returning
from the function, I would suggest using try/finally. However, since the current
working directory is only per application and this script just exit after
returning from main, I'm not even sure it is necessary to save the current
working directory.

Using try/finally would be something like:

pwd = os.getcwd()
try:
  os.chdir(framework)
  ...
  return 0
finally:
  os.chdir(pwd)

[Robert Sesek, 2016-06-09 14:19:59]

Patchset #2 (id:20001) has been deleted

[Robert Sesek, 2016-06-09 14:25:18]

https://codereview.chromium.org/2055673002/diff/1/build/config/mac/package_fr...
File build/config/mac/package_framework.py (right):

https://codereview.chromium.org/2055673002/diff/1/build/config/mac/package_fr...
build/config/mac/package_framework.py:19: binary =
os.path.basename(framework).split('.')[0]
On 2016/06/09 07:16:18, sdefresne wrote:
> nit: os.path.splitext(os.path.basename(framework))[0]

Done.

https://codereview.chromium.org/2055673002/diff/1/build/config/mac/package_fr...
build/config/mac/package_framework.py:31: pwd = os.getcwd()
On 2016/06/09 07:16:18, sdefresne wrote:
> If you want to be sure to restore the current working directory before
returning
> from the function, I would suggest using try/finally. However, since the
current
> working directory is only per application and this script just exit after
> returning from main, I'm not even sure it is necessary to save the current
> working directory.

I just dropped the cwd reset because, as you say, it's local to the process and
it exits right after this.

[Robert Sesek, 2016-06-09 14:43:39]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2016-06-09 14:43:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2055673002/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2016-06-09 14:44:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055673002/40001

[commit-bot: I haz the power, 2016-06-09 15:13:43]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-09 15:13:50]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-09 15:15:15]

Description was changed from

==========
[Mac/GN] Add //build/config/mac/package_framework.py.

This moves another step performed by gyp-mac-tool into a standalone script. In
addition, support for more top-level bundle directories (e.g. Helpers,
XPCServices,
etc.) is added.

BUG=616813,604809
R=sdefresne@chromium.org
==========

to

==========
[Mac/GN] Add //build/config/mac/package_framework.py.

This moves another step performed by gyp-mac-tool into a standalone script. In
addition, support for more top-level bundle directories (e.g. Helpers,
XPCServices,
etc.) is added.

BUG=616813,604809
R=sdefresne@chromium.org

Committed: https://crrev.com/51dc7dae178061bfcc559f16d85e43f2695efacf
Cr-Commit-Position: refs/heads/master@{#398884}
==========

[commit-bot: I haz the power, 2016-06-09 15:15:16]

Patchset 2 (id:??) landed as
https://crrev.com/51dc7dae178061bfcc559f16d85e43f2695efacf
Cr-Commit-Position: refs/heads/master@{#398884}