Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2055653002: Add OWNERS for some chrome/ sub-directories. (Closed)

Created:
4 years, 6 months ago by Lei Zhang
Modified:
4 years, 6 months ago
CC:
chromium-reviews, mlamouri (slow - plz ping)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add OWNERS for some chrome/ sub-directories. NOTRY=true Committed: https://crrev.com/a96e660f4d251c85f3bcb7f09647de7c85908f9a Cr-Commit-Position: refs/heads/master@{#401623}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A chrome/browser/custom_handlers/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/external_protocol/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/recovery/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/custom_handlers/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/renderer/banners/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Lei Zhang
Thanks for helping out!
4 years, 6 months ago (2016-06-09 00:12:08 UTC) #4
dominickn
I would also suggest mlamouri@chromium.org for chrome/renderer/banners
4 years, 6 months ago (2016-06-09 01:01:27 UTC) #6
benwells
lgtm https://codereview.chromium.org/2055653002/diff/40001/chrome/common/custom_handlers/OWNERS File chrome/common/custom_handlers/OWNERS (right): https://codereview.chromium.org/2055653002/diff/40001/chrome/common/custom_handlers/OWNERS#newcode1 chrome/common/custom_handlers/OWNERS:1: file://chrome/browser/custom_handlers/OWNERS Wow, fancy!
4 years, 6 months ago (2016-06-09 01:04:10 UTC) #7
Lei Zhang
On 2016/06/09 01:01:27, dominickn wrote: > I would also suggest mailto:mlamouri@chromium.org for chrome/renderer/banners ^ patch ...
4 years, 6 months ago (2016-06-09 01:06:56 UTC) #8
dominickn
On 2016/06/09 01:06:56, Lei Zhang (Slow) wrote: > On 2016/06/09 01:01:27, dominickn wrote: > > ...
4 years, 6 months ago (2016-06-09 05:58:35 UTC) #9
Lei Zhang
If there's no objections, I will land this in ~12 hours.
4 years, 6 months ago (2016-06-21 18:50:47 UTC) #10
meacer
On 2016/06/21 18:50:47, Lei Zhang wrote: > If there's no objections, I will land this ...
4 years, 6 months ago (2016-06-21 19:09:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055653002/60001
4 years, 6 months ago (2016-06-23 16:14:37 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 6 months ago (2016-06-23 16:21:14 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 16:22:46 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a96e660f4d251c85f3bcb7f09647de7c85908f9a
Cr-Commit-Position: refs/heads/master@{#401623}

Powered by Google App Engine
This is Rietveld 408576698