Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2055633002: The units for the CanvasExpansion should be pixels (Closed)

Created:
4 years, 6 months ago by RyanSturm
Modified:
4 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The units for the CanvasExpansion should be pixels YCanvasExpansion and XCavnasExpansion both measure how much the image canvas expanded due to first frame size being larger than canvas size. The units are currently in bytes, but should be in pixels. BUG=616582 Committed: https://crrev.com/4c58f3559782e9baab49ebecb19463b9afe0a9b1 Cr-Commit-Position: refs/heads/master@{#398955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
RyanSturm
asvitkine: PTAL
4 years, 6 months ago (2016-06-08 22:23:49 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 6 months ago (2016-06-09 17:28:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055633002/1
4 years, 6 months ago (2016-06-09 17:47:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 18:38:35 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 18:39:02 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 18:46:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c58f3559782e9baab49ebecb19463b9afe0a9b1
Cr-Commit-Position: refs/heads/master@{#398955}

Powered by Google App Engine
This is Rietveld 408576698