Chromium Code Reviews| Index: Source/devtools/front_end/CPUProfileView.js |
| diff --git a/Source/devtools/front_end/CPUProfileView.js b/Source/devtools/front_end/CPUProfileView.js |
| index b22f46f37443bee4d3d4315daafa737216a09e1a..6b17df50e9fc3eb03aa9fd90df7f6c0a655eb0a6 100644 |
| --- a/Source/devtools/front_end/CPUProfileView.js |
| +++ b/Source/devtools/front_end/CPUProfileView.js |
| @@ -52,7 +52,7 @@ WebInspector.CPUProfileView = function(profileHeader) |
| this.viewSelectComboBox = new WebInspector.StatusBarComboBox(this._changeView.bind(this)); |
| var options = {}; |
| - options[WebInspector.CPUProfileView._TypeFlame] = this.viewSelectComboBox.createOption(WebInspector.UIString("Flame Chart"), "", WebInspector.CPUProfileView._TypeFlame); |
| + options[WebInspector.CPUProfileView._TypeFlame] = this.viewSelectComboBox.createOption(WebInspector.UIString("Icicle Chart"), "", WebInspector.CPUProfileView._TypeFlame); |
| options[WebInspector.CPUProfileView._TypeHeavy] = this.viewSelectComboBox.createOption(WebInspector.UIString("Heavy (Bottom Up)"), "", WebInspector.CPUProfileView._TypeHeavy); |
| options[WebInspector.CPUProfileView._TypeTree] = this.viewSelectComboBox.createOption(WebInspector.UIString("Tree (Top Down)"), "", WebInspector.CPUProfileView._TypeTree); |
| @@ -1284,8 +1284,7 @@ WebInspector.CPUFlameChartDataProvider.prototype = { |
| var totalTime = this._millisecondsToString(timelineData.entryTotalTimes[entryIndex]); |
| pushEntryInfoRow(WebInspector.UIString("Self time"), selfTime); |
| pushEntryInfoRow(WebInspector.UIString("Total time"), totalTime); |
| - if (node.url) |
| - pushEntryInfoRow(WebInspector.UIString("URL"), node.url + ":" + node.lineNumber); |
| + pushEntryInfoRow(WebInspector.UIString("URL"), node.url ? node.url : WebInspector.UIString("VM%s", node.scriptId) + ":" + node.lineNumber); |
|
pfeldman
2014/03/25 16:32:22
You should create and linkify raw location instead
|
| pushEntryInfoRow(WebInspector.UIString("Aggregated self time"), Number.secondsToString(node.selfTime / 1000, true)); |
| pushEntryInfoRow(WebInspector.UIString("Aggregated total time"), Number.secondsToString(node.totalTime / 1000, true)); |
| if (node.deoptReason && node.deoptReason !== "no reason") |