CPUProfiler: convert Flame Chart into Icicle Chart

Source/devtools/front_end/CPUProfileView.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 34 matching lines @@
     columns.push({id: "function", title: WebInspector.UIString("Function"), disclosure: true, sortable: true});
 
     this.dataGrid = new WebInspector.DataGrid(columns);
     this.dataGrid.addEventListener(WebInspector.DataGrid.Events.SortingChanged, this._sortProfile, this);
     this.dataGrid.element.addEventListener("mousedown", this._mouseDownInDataGrid.bind(this), true);
     this.dataGrid.show(this.element);
 
     this.viewSelectComboBox = new WebInspector.StatusBarComboBox(this._changeView.bind(this));
 
     var options = {};
-    options[WebInspector.CPUProfileView._TypeFlame] = this.viewSelectComboBox.createOption(WebInspector.UIString("Flame Chart"), "", WebInspector.CPUProfileView._TypeFlame);
+    options[WebInspector.CPUProfileView._TypeFlame] = this.viewSelectComboBox.createOption(WebInspector.UIString("Icicle Chart"), "", WebInspector.CPUProfileView._TypeFlame);
     options[WebInspector.CPUProfileView._TypeHeavy] = this.viewSelectComboBox.createOption(WebInspector.UIString("Heavy (Bottom Up)"), "", WebInspector.CPUProfileView._TypeHeavy);
     options[WebInspector.CPUProfileView._TypeTree] = this.viewSelectComboBox.createOption(WebInspector.UIString("Tree (Top Down)"), "", WebInspector.CPUProfileView._TypeTree);
 
     var optionName = this._viewType.get() || WebInspector.CPUProfileView._TypeFlame;
     var option = options[optionName] || options[WebInspector.CPUProfileView._TypeFlame];
     this.viewSelectComboBox.select(option);
 
     this._statusBarButtonsElement = document.createElement("span");
 
     this.percentButton = new WebInspector.StatusBarButton("", "percent-time-status-bar-item");
@@ skipping 983 matching lines @@
 /**
  * @constructor
  * @implements {WebInspector.FlameChartDataProvider}
  * @param {!WebInspector.CPUProfileView} cpuProfileView
  */
 WebInspector.CPUFlameChartDataProvider = function(cpuProfileView)
 {
     WebInspector.FlameChartDataProvider.call(this);
     this._cpuProfileView = cpuProfileView;
     this._colorGenerator = WebInspector.CPUProfileView.colorGenerator();
+    this._linkifier = new WebInspector.Linkifier();
 }
 
 WebInspector.CPUFlameChartDataProvider.prototype = {
     /**
      * @return {number}
      */
     barHeight: function()
     {
         return 15;
     },
@@ skipping 208 matching lines @@
             row.title = title;
             row.text = text;
             entryInfo.push(row);
         }
 
         pushEntryInfoRow(WebInspector.UIString("Name"), node.functionName);
         var selfTime = this._millisecondsToString(this._entrySelfTimes[entryIndex]);
         var totalTime = this._millisecondsToString(timelineData.entryTotalTimes[entryIndex]);
         pushEntryInfoRow(WebInspector.UIString("Self time"), selfTime);
         pushEntryInfoRow(WebInspector.UIString("Total time"), totalTime);
-        if (node.url)
-            pushEntryInfoRow(WebInspector.UIString("URL"), node.url + ":" + node.lineNumber);
+        var linkElement = this._linkifier.linkifyRawLocation(new WebInspector.DebuggerModel.Location(node.scriptId, node.lineNumber, node.columnNumber));

[pfeldman, 2014/03/26 09:33:46]

just create local linkifier.

+        pushEntryInfoRow(WebInspector.UIString("URL"), linkElement ? linkElement.innerText : "");

[pfeldman, 2014/03/26 09:33:46]

You should never use innerText. Use textContent instead.

+        // We need only text of the link so we can reset linkifier immedeately.
+        // Othervise linkifier will keep the references to the elements and update them each time when user clicks pretty print.
+        this._linkifier.reset();
         pushEntryInfoRow(WebInspector.UIString("Aggregated self time"), Number.secondsToString(node.selfTime / 1000, true));
         pushEntryInfoRow(WebInspector.UIString("Aggregated total time"), Number.secondsToString(node.totalTime / 1000, true));
         if (node.deoptReason && node.deoptReason !== "no reason")
             pushEntryInfoRow(WebInspector.UIString("Not optimized"), node.deoptReason);
 
         return entryInfo;
     },
 
     /**
      * @param {number} entryIndex
@@ skipping 87 matching lines @@
 
     /**
      * @param {number} entryIndex
      * @return {!string}
      */
     textColor: function(entryIndex)
     {
         return "#333";
     }
 }