Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 205563007: CPUProfiler: convert Flame Chart into Icicle Chart (Closed)

Created:
6 years, 9 months ago by loislo
Modified:
6 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

CPUProfiler: convert Flame Chart into Icicle Chart BUG= R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170140

Patch Set 1 #

Patch Set 2 : minor changes #

Total comments: 1

Patch Set 3 : linkifier #

Total comments: 2

Patch Set 4 : liveLocationText static method was added for text #

Total comments: 1

Patch Set 5 : the function was moved to Script.js #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M Source/devtools/front_end/CPUProfileView.js View 1 2 3 4 2 chunks +3 lines, -3 lines 1 comment Download
M Source/devtools/front_end/FlameChart.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/Linkifier.js View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M Source/devtools/front_end/profilesPanel.css View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
loislo
6 years, 9 months ago (2014-03-25 11:31:58 UTC) #1
pfeldman
https://codereview.chromium.org/205563007/diff/20001/Source/devtools/front_end/CPUProfileView.js File Source/devtools/front_end/CPUProfileView.js (right): https://codereview.chromium.org/205563007/diff/20001/Source/devtools/front_end/CPUProfileView.js#newcode1287 Source/devtools/front_end/CPUProfileView.js:1287: pushEntryInfoRow(WebInspector.UIString("URL"), node.url ? node.url : WebInspector.UIString("VM%s", node.scriptId) + ":" ...
6 years, 9 months ago (2014-03-25 16:32:22 UTC) #2
loislo
On 2014/03/25 16:32:22, pfeldman wrote: > https://codereview.chromium.org/205563007/diff/20001/Source/devtools/front_end/CPUProfileView.js > File Source/devtools/front_end/CPUProfileView.js (right): > > https://codereview.chromium.org/205563007/diff/20001/Source/devtools/front_end/CPUProfileView.js#newcode1287 > ...
6 years, 9 months ago (2014-03-25 17:13:53 UTC) #3
pfeldman
https://codereview.chromium.org/205563007/diff/60001/Source/devtools/front_end/CPUProfileView.js File Source/devtools/front_end/CPUProfileView.js (right): https://codereview.chromium.org/205563007/diff/60001/Source/devtools/front_end/CPUProfileView.js#newcode1288 Source/devtools/front_end/CPUProfileView.js:1288: var linkElement = this._linkifier.linkifyRawLocation(new WebInspector.DebuggerModel.Location(node.scriptId, node.lineNumber, node.columnNumber)); just create ...
6 years, 9 months ago (2014-03-26 09:33:45 UTC) #4
loislo
On 2014/03/26 09:33:45, pfeldman wrote: > https://codereview.chromium.org/205563007/diff/60001/Source/devtools/front_end/CPUProfileView.js > File Source/devtools/front_end/CPUProfileView.js (right): > > https://codereview.chromium.org/205563007/diff/60001/Source/devtools/front_end/CPUProfileView.js#newcode1288 > ...
6 years, 9 months ago (2014-03-26 13:27:33 UTC) #5
pfeldman
https://codereview.chromium.org/205563007/diff/110001/Source/devtools/front_end/Script.js File Source/devtools/front_end/Script.js (right): https://codereview.chromium.org/205563007/diff/110001/Source/devtools/front_end/Script.js#newcode315 Source/devtools/front_end/Script.js:315: WebInspector.Script.liveLocationText = function(scriptId, lineNumber, columnNumber) This should be on ...
6 years, 9 months ago (2014-03-26 14:13:13 UTC) #6
pfeldman
lgtm https://codereview.chromium.org/205563007/diff/160001/Source/devtools/front_end/CPUProfileView.js File Source/devtools/front_end/CPUProfileView.js (right): https://codereview.chromium.org/205563007/diff/160001/Source/devtools/front_end/CPUProfileView.js#newcode55 Source/devtools/front_end/CPUProfileView.js:55: options[WebInspector.CPUProfileView._TypeFlame] = this.viewSelectComboBox.createOption(WebInspector.UIString("Icicle Chart"), "", WebInspector.CPUProfileView._TypeFlame); I wonder ...
6 years, 9 months ago (2014-03-26 14:40:24 UTC) #7
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 9 months ago (2014-03-26 15:06:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/205563007/160001
6 years, 9 months ago (2014-03-26 15:06:44 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 15:14:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-26 15:14:56 UTC) #11
loislo
6 years, 9 months ago (2014-03-27 05:37:12 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 manually as r170140 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698