content/renderer/service_worker/service_worker_script_context.h - Issue 205563006: Add a status code to install event handled message from Service Worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_script_context.h

Issue 205563006: Add a status code to install event handled message from Service Worker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add comment and fix alphabetical ordering Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/DEPS ('K') | « content/renderer/service_worker/embedded_worker_context_client.cc ('k') | content/renderer/service_worker/service_worker_script_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_script_context.h

diff --git a/content/renderer/service_worker/service_worker_script_context.h b/content/renderer/service_worker/service_worker_script_context.h

index 7bea6bfbf16d1687435d9ecdd514ff741a38f508..1a90ceb450beca17280ffab04708203935bac1b9 100644

--- a/content/renderer/service_worker/service_worker_script_context.h

+++ b/content/renderer/service_worker/service_worker_script_context.h

@@ -11,6 +11,7 @@

#include "base/strings/string16.h"

#include "content/common/service_worker/service_worker_types.h"

+#include "third_party/WebKit/public/platform/WebServiceWorkerEventResult.h"

namespace blink {

class WebServiceWorkerContextProxy;

@@ -37,7 +38,8 @@ class ServiceWorkerScriptContext {

void OnMessageReceived(int request_id, const IPC::Message& message);

- void DidHandleInstallEvent(int request_id);

+ void DidHandleInstallEvent(int request_id,

+ blink::WebServiceWorkerEventResult result);

void DidHandleFetchEvent(int request_id,

ServiceWorkerFetchEventResult result,

const ServiceWorkerResponse& response);

@@ -46,7 +48,7 @@ class ServiceWorkerScriptContext {

// Send message back to the browser.

void Send(int request_id, const IPC::Message& message);

- void OnInstallEvent(int active_version_embedded_worker_id);

+ void OnInstallEvent(int active_version_id);

void OnFetchEvent(const ServiceWorkerFetchRequest& request);

void OnPostMessage(const base::string16& message,

const std::vector<int>& sent_message_port_ids,