Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.cc

Issue 205563006: Add a status code to install event handled message from Service Worker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add comment and fix alphabetical ordering Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_test_helper.cc
diff --git a/content/browser/service_worker/embedded_worker_test_helper.cc b/content/browser/service_worker/embedded_worker_test_helper.cc
index 70f7f0cb36710a6f57f605fe107abdde04408f0e..6617eea4f0bcc344cb56cda6d40d8f74a417d214 100644
--- a/content/browser/service_worker/embedded_worker_test_helper.cc
+++ b/content/browser/service_worker/embedded_worker_test_helper.cc
@@ -87,14 +87,14 @@ bool EmbeddedWorkerTestHelper::OnSendMessageToWorker(
return handled;
}
-void EmbeddedWorkerTestHelper::OnInstallEvent(
- int embedded_worker_id,
- int request_id,
- int active_version_embedded_worker_id) {
+void EmbeddedWorkerTestHelper::OnInstallEvent(int embedded_worker_id,
+ int request_id,
+ int active_version_id) {
SimulateSendMessageToBrowser(
embedded_worker_id,
request_id,
- ServiceWorkerHostMsg_InstallEventFinished());
+ ServiceWorkerHostMsg_InstallEventFinished(
+ blink::WebServiceWorkerEventResultCompleted));
}
void EmbeddedWorkerTestHelper::OnFetchEvent(
@@ -179,15 +179,14 @@ void EmbeddedWorkerTestHelper::OnSendMessageToWorkerStub(
message));
}
-void EmbeddedWorkerTestHelper::OnInstallEventStub(
- int active_version_embedded_worker_id) {
+void EmbeddedWorkerTestHelper::OnInstallEventStub(int active_version_id) {
base::MessageLoopProxy::current()->PostTask(
FROM_HERE,
base::Bind(&EmbeddedWorkerTestHelper::OnInstallEvent,
weak_factory_.GetWeakPtr(),
current_embedded_worker_id_,
current_request_id_,
- active_version_embedded_worker_id));
+ active_version_id));
}
void EmbeddedWorkerTestHelper::OnFetchEventStub(

Powered by Google App Engine
This is Rietveld 408576698