Report hash of Chrome's parent process name.

Report hash of Chrome's parent process name.

This is in order to try and correlate Chrome stability with parent
process name.

BUG=385714
Committed: https://crrev.com/be98b758f1827a26dcf4582c4286f10bdd8bc65b
Cr-Commit-Position: refs/heads/master@{#398929}

[Will Harris, 2016-06-08 22:10:08]

Description was changed from

==========
Report hash of Chrome's parent process name.

This is in order to try and correlete Chrome stability with parent
process name.

BUG=385714
==========

to

==========
Report hash of Chrome's parent process name.

This is in order to try and correlete Chrome stability with parent
process name.

BUG=385714
==========

[Will Harris, 2016-06-08 22:10:09]

wfh@chromium.org changed reviewers:
+ robertshield@chromium.org

[Will Harris, 2016-06-08 22:10:36]

WDYT? This seemed like a convenient place to do this work, since it's happening
on the blocking pool after startup.

[brucedawson, 2016-06-08 23:01:38]

Description was changed from

==========
Report hash of Chrome's parent process name.

This is in order to try and correlete Chrome stability with parent
process name.

BUG=385714
==========

to

==========
Report hash of Chrome's parent process name.

This is in order to try and correlate Chrome stability with parent
process name.

BUG=385714
==========

[robertshield, 2016-06-09 03:29:59]

LGTM

I'd expect there to be a fair number of "0" value hits in cases where something
launches chrome.exe then quits, but it doesn't seem important enough to run this
any earlier to reduce those.

https://codereview.chromium.org/2055613002/diff/20001/chrome/browser/install_...
File chrome/browser/install_verification/win/install_verification.cc (right):

https://codereview.chromium.org/2055613002/diff/20001/chrome/browser/install_...
chrome/browser/install_verification/win/install_verification.cc:63: if
(!path.empty())
nit: I thought we needed {} if the statement below spans multiple lines. Ignore
this comment if git cl format suggested this.

[Will Harris, 2016-06-09 03:35:46]

wfh@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Will Harris, 2016-06-09 03:35:47]

Yup I got a 0 from a first run after install when testing... We will get quite a
lot of these, but agree there isn't too much point dealing with them, as we can
hopefully filter them out...

+asvitkine for histograms.

https://codereview.chromium.org/2055613002/diff/20001/chrome/browser/install_...
File chrome/browser/install_verification/win/install_verification.cc (right):

https://codereview.chromium.org/2055613002/diff/20001/chrome/browser/install_...
chrome/browser/install_verification/win/install_verification.cc:63: if
(!path.empty())
On 2016/06/09 03:29:59, robertshield wrote:
> nit: I thought we needed {} if the statement below spans multiple lines.
Ignore
> this comment if git cl format suggested this. 

git cl format never adds braces even when they are needed...

In this case you're right and I'll add them.

[Alexei Svitkine (slow), 2016-06-09 15:04:26]

lgtm

https://codereview.chromium.org/2055613002/diff/20001/chrome/browser/install_...
File chrome/browser/install_verification/win/install_verification.cc (right):

https://codereview.chromium.org/2055613002/diff/20001/chrome/browser/install_...
chrome/browser/install_verification/win/install_verification.cc:65:
metrics::HashName(base::ToLowerASCII(path.BaseName().AsUTF8Unsafe()));
Nit: AsUTF8Unsafe() stands out and makes the reader question if this is correct.

How about just using UTF16ToUTF8() on .value() - since on Windows Filepath uses
string16 as the value type.

[Will Harris, 2016-06-09 16:22:51]

Thanks for speedy reviews!

https://codereview.chromium.org/2055613002/diff/20001/chrome/browser/install_...
File chrome/browser/install_verification/win/install_verification.cc (right):

https://codereview.chromium.org/2055613002/diff/20001/chrome/browser/install_...
chrome/browser/install_verification/win/install_verification.cc:63: if
(!path.empty())
On 2016/06/09 03:35:47, Will Harris wrote:
> On 2016/06/09 03:29:59, robertshield wrote:
> > nit: I thought we needed {} if the statement below spans multiple lines.
> Ignore
> > this comment if git cl format suggested this. 
> 
> git cl format never adds braces even when they are needed...
> 
> In this case you're right and I'll add them.

Done.

https://codereview.chromium.org/2055613002/diff/20001/chrome/browser/install_...
chrome/browser/install_verification/win/install_verification.cc:65:
metrics::HashName(base::ToLowerASCII(path.BaseName().AsUTF8Unsafe()));
On 2016/06/09 15:04:26, Alexei Svitkine (slow) wrote:
> Nit: AsUTF8Unsafe() stands out and makes the reader question if this is
correct.
> 
> How about just using UTF16ToUTF8() on .value() - since on Windows Filepath
uses
> string16 as the value type.

Done.

[Will Harris, 2016-06-09 16:22:54]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2016-06-09 16:22:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertshield@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2055613002/#ps40001
(title: "code review changes")

[commit-bot: I haz the power, 2016-06-09 16:23:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055613002/40001

[commit-bot: I haz the power, 2016-06-09 17:24:15]

Description was changed from

==========
Report hash of Chrome's parent process name.

This is in order to try and correlate Chrome stability with parent
process name.

BUG=385714
==========

to

==========
Report hash of Chrome's parent process name.

This is in order to try and correlate Chrome stability with parent
process name.

BUG=385714
==========

[commit-bot: I haz the power, 2016-06-09 17:24:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-09 17:27:45]

Description was changed from

==========
Report hash of Chrome's parent process name.

This is in order to try and correlate Chrome stability with parent
process name.

BUG=385714
==========

to

==========
Report hash of Chrome's parent process name.

This is in order to try and correlate Chrome stability with parent
process name.

BUG=385714

Committed: https://crrev.com/be98b758f1827a26dcf4582c4286f10bdd8bc65b
Cr-Commit-Position: refs/heads/master@{#398929}
==========

[commit-bot: I haz the power, 2016-06-09 17:27:47]

Patchset 3 (id:??) landed as
https://crrev.com/be98b758f1827a26dcf4582c4286f10bdd8bc65b
Cr-Commit-Position: refs/heads/master@{#398929}