Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2055543002: SDK summary creation generalization (pt 1). (Closed)

Created:
4 years, 6 months ago by pquitslund
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

SDK summary creation generalization (pt 1). Steps towards generalizing summary creation bits (to allow for, among other things, flutter SDK summary creation). API is provisional (note still in `lib/src`). Next up: * move result writing out of `tool/` to allow for reuse * `SummaryBuilder.forPackageMap(..)` factory (or similar) for use in the flutter SDK case BUG= R=brianwilkerson@google.com, paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/1eefb68c25d57adf77cb83dd424814df8901fd31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -110 lines) Patch
A pkg/analyzer/lib/src/summary/summary_file_builder.dart View 1 chunk +128 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/summary/build_sdk_summaries.dart View 3 chunks +15 lines, -110 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 6 months ago (2016-06-08 20:45:49 UTC) #2
Brian Wilkerson
lgtm, but I'm not very familiar with the code, so I'm not sure that means ...
4 years, 6 months ago (2016-06-08 21:50:05 UTC) #3
Paul Berry
lgtm
4 years, 6 months ago (2016-06-09 16:58:26 UTC) #4
pquitslund
4 years, 6 months ago (2016-06-09 19:06:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1eefb68c25d57adf77cb83dd424814df8901fd31 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698