Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 205553003: Invalidation not taking glyph bounds into account on HarfBuzz path (Closed)

Created:
6 years, 9 months ago by eae
Modified:
6 years, 9 months ago
Reviewers:
dglazkov, behdad
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Invalidation not taking glyph bounds into account on HarfBuzz path Implement support for computing and populating the GlyphOverflow structure for the harfbuzz code path. The current implementation is a straight copy of the current Mac implementation with minor modifications to use the corresponding harfbuzz APIs. R=dglazkov@chromium.org,behdad@chromium.org BUG=354165 TEST=fast/text/international/repaint-glyph-bounds.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169605

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/text/international/repaint-glyph-bounds.html View 1 chunk +47 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/international/repaint-glyph-bounds-expected.html View 1 chunk +31 lines, -0 lines 0 comments Download
M Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M Source/platform/fonts/harfbuzz/HarfBuzzShaper.h View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp View 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eae
6 years, 9 months ago (2014-03-19 23:14:50 UTC) #1
behdad
lgtm
6 years, 9 months ago (2014-03-19 23:23:01 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-20 00:08:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/205553003/20001
6 years, 9 months ago (2014-03-20 00:09:07 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 00:09:08 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-20 00:09:09 UTC) #6
dglazkov
lgtm
6 years, 9 months ago (2014-03-20 00:29:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/205553003/20001
6 years, 9 months ago (2014-03-20 00:29:57 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 03:55:05 UTC) #9
Message was sent while issue was closed.
Change committed as 169605

Powered by Google App Engine
This is Rietveld 408576698