Allow Chromium's DBus service ownership to be stealable

chrome/browser/chromeos/dbus/cros_dbus_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/dbus/cros_dbus_service.h"
 
 #include "base/bind.h"
 #include "base/chromeos/chromeos_version.h"
 #include "base/stl_util.h"
 #include "base/threading/platform_thread.h"
@@ skipping 32 matching lines @@
   void Start() {
     // Make sure we're running on the origin thread (i.e. the UI thread in
     // production).
     DCHECK(OnOriginThread());
 
     // Return if the service has been already started.
     if (service_started_)
       return;
 
     bus_->RequestOwnership(kLibCrosServiceName,
+                           dbus::Bus::REQUIRE_PRIMARY_ALLOW_REPLACEMENT,

[satorux1, 2013/07/26 01:14:45]

Please add some comment about why we are allowing replacement here as it's not
obvious. Having a pointer to crbug.com URL would be nice.

[Chris Masone, 2013/07/26 17:37:24]

Done.

                            base::Bind(&CrosDBusServiceImpl::OnOwnership,
                                       base::Unretained(this)));
 
     exported_object_ = bus_->GetExportedObject(
         dbus::ObjectPath(kLibCrosServicePath));
 
     for (size_t i = 0; i < service_providers_.size(); ++i)
       service_providers_[i]->Start(exported_object_);
 
     service_started_ = true;
@@ skipping 82 matching lines @@
   VLOG(1) << "CrosDBusService Shutdown completed";
 }
 
 CrosDBusService::~CrosDBusService() {
 }
 
 CrosDBusService::ServiceProviderInterface::~ServiceProviderInterface() {
 }
 
 }  // namespace chromeos