gl: Add YVU_420 support to GLImageOzoneNativePixmap.

gl: Add YVU_420 support to GLImageOzoneNativePixmap.

This CL adds support to import and use YVU_420 buffers in
GLImageOzoneNativePixmap.

BUG=618516
TEST=crrev.com/2052543004

Committed: https://crrev.com/e2390b4b8465b82a2107233a5f592467a7c0ab05
Cr-Commit-Position: refs/heads/master@{#398900}

[Daniele Castagna, 2016-06-08 21:30:34]

Description was changed from

==========
Add YUV_420 support to GLImageOzoneNativePixmap.

This CL adds support to import to use YVU_420 buffer in
GLImageOzoneNativePixmap.

TEST=crrev.com/2040803002
==========

to

==========
gl: Add YVU_420 support to GLImageOzoneNativePixmap.

This CL adds support to import to use YVU_420 buffers in
GLImageOzoneNativePixmap.

TEST=crrev.com/2040803002
==========

[Daniele Castagna, 2016-06-08 21:31:53]

dcastagna@chromium.org changed reviewers:
+ reveman@chromium.org

[Daniele Castagna, 2016-06-08 21:32:09]

dcastagna@chromium.org changed reviewers:
+ dnicoara@chromium.org, posciak@chromium.org

[Daniele Castagna, 2016-06-08 21:33:46]

Description was changed from

==========
gl: Add YVU_420 support to GLImageOzoneNativePixmap.

This CL adds support to import to use YVU_420 buffers in
GLImageOzoneNativePixmap.

TEST=crrev.com/2040803002
==========

to

==========
gl: Add YVU_420 support to GLImageOzoneNativePixmap.

This CL adds support to import and use YVU_420 buffers in
GLImageOzoneNativePixmap.

TEST=crrev.com/2040803002
==========

[reveman, 2016-06-08 21:48:31]

https://codereview.chromium.org/2055483002/diff/1/ui/gl/gl_image_ozone_native...
File ui/gl/gl_image_ozone_native_pixmap.cc (right):

https://codereview.chromium.org/2055483002/diff/1/ui/gl/gl_image_ozone_native...
ui/gl/gl_image_ozone_native_pixmap.cc:145: // i965 driver expects all the fds to
have the same value.
Can we change the GLImageOzone native pixmap API to allow the fd for plane=1,
plane=2 to be invalid and use that to detect that we should just use fd[0] for
all planes instead of this ifdef?

This way the device specific code that produce these fds and knows this hack is
needed can instead make the adjustment and we can avoid the ifdefs here. Wdyt?

[Daniele Castagna, 2016-06-09 00:12:08]

Patchset #2 (id:20001) has been deleted

[Daniele Castagna, 2016-06-09 00:26:24]

https://codereview.chromium.org/2055483002/diff/1/ui/gl/gl_image_ozone_native...
File ui/gl/gl_image_ozone_native_pixmap.cc (right):

https://codereview.chromium.org/2055483002/diff/1/ui/gl/gl_image_ozone_native...
ui/gl/gl_image_ozone_native_pixmap.cc:145: // i965 driver expects all the fds to
have the same value.
On 2016/06/08 at 21:48:30, reveman wrote:
> Can we change the GLImageOzone native pixmap API to allow the fd for plane=1,
plane=2 to be invalid and use that to detect that we should just use fd[0] for
all planes instead of this ifdef?
> 
> This way the device specific code that produce these fds and knows this hack
is needed can instead make the adjustment and we can avoid the ifdefs here.
Wdyt?

Done as discussed.

[Daniele Castagna, 2016-06-09 00:52:00]

Description was changed from

==========
gl: Add YVU_420 support to GLImageOzoneNativePixmap.

This CL adds support to import and use YVU_420 buffers in
GLImageOzoneNativePixmap.

TEST=crrev.com/2040803002
==========

to

==========
gl: Add YVU_420 support to GLImageOzoneNativePixmap.

This CL adds support to import and use YVU_420 buffers in
GLImageOzoneNativePixmap.

BUG=618516
TEST=crrev.com/2040803002
==========

[reveman, 2016-06-09 01:00:10]

lgtm

[Daniele Castagna, 2016-06-09 01:01:40]

+ccameron for owner approval on ui/ozone/public/native_pixmap.h and
ui/ozone/platform/{cast,headless}/*

[Daniele Castagna, 2016-06-09 01:02:06]

dcastagna@chromium.org changed reviewers:
+ ccameron@chromium.org

[Daniele Castagna, 2016-06-09 01:02:07]

Actually adding Chris for ownership.

[Daniele Castagna, 2016-06-09 01:02:31]

Description was changed from

==========
gl: Add YVU_420 support to GLImageOzoneNativePixmap.

This CL adds support to import and use YVU_420 buffers in
GLImageOzoneNativePixmap.

BUG=618516
TEST=crrev.com/2040803002
==========

to

==========
gl: Add YVU_420 support to GLImageOzoneNativePixmap.

This CL adds support to import and use YVU_420 buffers in
GLImageOzoneNativePixmap.

BUG=618516
TEST=crrev.com/2040803002
==========

[dnicoara, 2016-06-09 01:17:03]

lgtm

https://codereview.chromium.org/2055483002/diff/60001/ui/ozone/platform/cast/...
File ui/ozone/platform/cast/surface_factory_cast.cc (right):

https://codereview.chromium.org/2055483002/diff/60001/ui/ozone/platform/cast/...
ui/ozone/platform/cast/surface_factory_cast.cc:257: size_t GetDmaBufFdNum()
const override { return 0; };
nit: Last semicolon isn't needed.

https://codereview.chromium.org/2055483002/diff/60001/ui/ozone/public/native_...
File ui/ozone/public/native_pixmap.h (right):

https://codereview.chromium.org/2055483002/diff/60001/ui/ozone/public/native_...
ui/ozone/public/native_pixmap.h:30: virtual size_t GetDmaBufFdNum() const = 0;
nit: Not sure how others feel, but I was a bit confused at first by the "Num"
suffix. Perhaps use "Count"?

But I don't have a strong opinion on this.

[Daniele Castagna, 2016-06-09 01:27:21]

Description was changed from

==========
gl: Add YVU_420 support to GLImageOzoneNativePixmap.

This CL adds support to import and use YVU_420 buffers in
GLImageOzoneNativePixmap.

BUG=618516
TEST=crrev.com/2040803002
==========

to

==========
gl: Add YVU_420 support to GLImageOzoneNativePixmap.

This CL adds support to import and use YVU_420 buffers in
GLImageOzoneNativePixmap.

BUG=618516
TEST=crrev.com/2052543004
==========

[Daniele Castagna, 2016-06-09 01:27:58]

https://codereview.chromium.org/2055483002/diff/60001/ui/ozone/platform/cast/...
File ui/ozone/platform/cast/surface_factory_cast.cc (right):

https://codereview.chromium.org/2055483002/diff/60001/ui/ozone/platform/cast/...
ui/ozone/platform/cast/surface_factory_cast.cc:257: size_t GetDmaBufFdNum()
const override { return 0; };
On 2016/06/09 at 01:17:02, dnicoara wrote:
> nit: Last semicolon isn't needed.

Done.

https://codereview.chromium.org/2055483002/diff/60001/ui/ozone/public/native_...
File ui/ozone/public/native_pixmap.h (right):

https://codereview.chromium.org/2055483002/diff/60001/ui/ozone/public/native_...
ui/ozone/public/native_pixmap.h:30: virtual size_t GetDmaBufFdNum() const = 0;
On 2016/06/09 at 01:17:02, dnicoara wrote:
> nit: Not sure how others feel, but I was a bit confused at first by the "Num"
suffix. Perhaps use "Count"?
> 
> But I don't have a strong opinion on this.

Count seems better. Done.

[ccameron, 2016-06-09 06:22:22]

OWNER rs lgtm

[Daniele Castagna, 2016-06-09 15:58:40]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2016-06-09 15:58:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
dnicoara@chromium.org, reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2055483002/#ps80001
(title: "s/Num/Count.")

[commit-bot: I haz the power, 2016-06-09 15:59:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055483002/80001

[commit-bot: I haz the power, 2016-06-09 16:10:26]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-06-09 16:11:49]

Description was changed from

==========
gl: Add YVU_420 support to GLImageOzoneNativePixmap.

This CL adds support to import and use YVU_420 buffers in
GLImageOzoneNativePixmap.

BUG=618516
TEST=crrev.com/2052543004
==========

to

==========
gl: Add YVU_420 support to GLImageOzoneNativePixmap.

This CL adds support to import and use YVU_420 buffers in
GLImageOzoneNativePixmap.

BUG=618516
TEST=crrev.com/2052543004

Committed: https://crrev.com/e2390b4b8465b82a2107233a5f592467a7c0ab05
Cr-Commit-Position: refs/heads/master@{#398900}
==========

[commit-bot: I haz the power, 2016-06-09 16:11:50]

Patchset 4 (id:??) landed as
https://crrev.com/e2390b4b8465b82a2107233a5f592467a7c0ab05
Cr-Commit-Position: refs/heads/master@{#398900}