xfa/fxjse/class.cpp - Issue 2055473004: Fix crash in CXFA_Node::TryUserData() (speculative)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxjse/class.cpp

Issue 2055473004: Fix crash in CXFA_Node::TryUserData() (speculative) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxjse/class.cpp

diff --git a/xfa/fxjse/class.cpp b/xfa/fxjse/class.cpp

index bd589453f298fab46b23bef0f7420127548dfc59..e9d67d8cdad70624a16b52a953717ada945f903d 100644

--- a/xfa/fxjse/class.cpp

+++ b/xfa/fxjse/class.cpp

@@ -147,7 +147,8 @@ CFX_ByteString CFXJSE_Arguments::GetUTF8String(int32_t index) const {

return CFX_ByteString(*szStringVal);

}

-void* CFXJSE_Arguments::GetObject(int32_t index, CFXJSE_Class* pClass) const {

+CFXJSE_HostObject* CFXJSE_Arguments::GetObject(int32_t index,

+ CFXJSE_Class* pClass) const {

v8::Local<v8::Value> hValue = (*m_pInfo)[index];

ASSERT(!hValue.IsEmpty());

if (!hValue->IsObject())

« no previous file with comments | « xfa/fxjse/cfxjse_arguments.h ('k') | xfa/fxjse/include/fxjse.h » ('j') | no next file with comments »