Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2055453003: Support running Viewer via android_gdb_app (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
Reviewers:
djsollen, liyuqian
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Support running Viewer via android_gdb_app BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055453003 Committed: https://skia.googlesource.com/skia/+/28215d44b3f9d100ba4420df43adb72cdff7d2b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M platform_tools/android/bin/android_gdb_app View 2 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Brian Osman
Just merged in some structure from android_launch_app, basically.
4 years, 6 months ago (2016-06-08 19:11:05 UTC) #3
djsollen
lgtm
4 years, 6 months ago (2016-06-08 19:13:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055453003/1
4 years, 6 months ago (2016-06-08 19:23:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/9031) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
4 years, 6 months ago (2016-06-08 19:24:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055453003/1
4 years, 6 months ago (2016-06-08 19:52:43 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 20:07:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/28215d44b3f9d100ba4420df43adb72cdff7d2b3

Powered by Google App Engine
This is Rietveld 408576698