|
|
Created:
6 years, 9 months ago by nasko Modified:
6 years, 9 months ago Reviewers:
Charlie Reis CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAdd filtering of IPC messages when RenderFrameHost is swapped out.
BUG=351815
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258521
Patch Set 1 #Patch Set 2 : Check only RVH state, as RFH state isn't properly updated. #Messages
Total messages: 18 (0 generated)
Hey Charlie, Can you review this CL with just a fix for the bug? As discussed, the test will be in a separate CL, which I've already sent out. Thanks! Nasko
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/205543002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
The CQ bit was checked by nasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/205543002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
Hey Charlie, We don't update properly the swapped out state for RFH, so we can't really rely on it for filtering messages. We should only use the RVH state, until we have moved all the code/state over to RFH. Can you take another look? Thanks, Nasko
Sure, we can update it when we move the swapped out state to RFH. LGTM.
The CQ bit was checked by nasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/205543002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by nasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/205543002/20001
Message was sent while issue was closed.
Change committed as 258521 |