Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 205543002: Add filtering of IPC messages when RenderFrameHost is swapped out. (Closed)

Created:
6 years, 9 months ago by nasko
Modified:
6 years, 9 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Add filtering of IPC messages when RenderFrameHost is swapped out. BUG=351815 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258521

Patch Set 1 #

Patch Set 2 : Check only RVH state, as RFH state isn't properly updated. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
nasko
Hey Charlie, Can you review this CL with just a fix for the bug? As ...
6 years, 9 months ago (2014-03-19 23:00:24 UTC) #1
Charlie Reis
lgtm
6 years, 9 months ago (2014-03-19 23:01:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/205543002/1
6 years, 9 months ago (2014-03-19 23:02:32 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 00:31:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-20 00:31:28 UTC) #5
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 9 months ago (2014-03-20 00:39:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/205543002/1
6 years, 9 months ago (2014-03-20 00:41:20 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 01:03:02 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-20 01:03:02 UTC) #9
nasko
Hey Charlie, We don't update properly the swapped out state for RFH, so we can't ...
6 years, 9 months ago (2014-03-20 21:03:32 UTC) #10
Charlie Reis
Sure, we can update it when we move the swapped out state to RFH. LGTM.
6 years, 9 months ago (2014-03-20 21:05:48 UTC) #11
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 9 months ago (2014-03-20 21:07:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/205543002/20001
6 years, 9 months ago (2014-03-20 21:08:50 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 23:20:33 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=285612
6 years, 9 months ago (2014-03-20 23:20:33 UTC) #15
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 9 months ago (2014-03-20 23:50:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/205543002/20001
6 years, 9 months ago (2014-03-20 23:51:49 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 11:21:42 UTC) #18
Message was sent while issue was closed.
Change committed as 258521

Powered by Google App Engine
This is Rietveld 408576698