Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2055393002: Revert of Mojo interface for Leak Detector on remote process (Closed)

Created:
4 years, 6 months ago by Simon Que
Modified:
4 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, asvitkine+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, bccheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojo interface for Leak Detector on remote process (patchset #2 id:20001 of https://codereview.chromium.org/2018983004/ ) Reason for revert: Need to re-submit mojom interface and implementation in single CL, and get security review from IPC owners. Original issue's description: > Mojo interface for Leak Detector on remote process > > This interface allows an instance of the Runtime Memory Leak Detector > (components/metrics/leak_detector) to run on a non-browser process, such > as a tab (renderer) process. The interface provides two function APIs: > > - GetParams(): Returns the profiling parameters used for initializing > LeakDetector. > - SendLeakReports(): Passes an array of leak reports in serialized proto > format (strings) to the browser process, where they can be attached to > the UMA protobuf. > > BUG=chromium:615223 > TEST=Build successfully > R=asvitkine@chromium.org > > Committed: https://crrev.com/51e4f33eae448bae4c95fde5a8f16d6d2e6e6960 > Cr-Commit-Position: refs/heads/master@{#396780} TBR=asvitkine@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:615223 Committed: https://crrev.com/9633249c6abb05f454533bf12b373e55f3020c09 Cr-Commit-Position: refs/heads/master@{#399359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M components/metrics.gypi View 1 chunk +0 lines, -10 lines 0 comments Download
M components/metrics/BUILD.gn View 2 chunks +0 lines, -10 lines 0 comments Download
D components/metrics/leak_detector/leak_detector_remote.mojom View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Simon Que
Created Revert of Mojo interface for Leak Detector on remote process
4 years, 6 months ago (2016-06-10 21:51:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055393002/1
4 years, 6 months ago (2016-06-10 21:52:57 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-10 21:52:59 UTC) #5
Simon Que
4 years, 6 months ago (2016-06-10 21:56:14 UTC) #7
Will Harris
lgtm
4 years, 6 months ago (2016-06-10 21:57:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055393002/1
4 years, 6 months ago (2016-06-10 21:59:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/151599) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 6 months ago (2016-06-10 22:06:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055393002/1
4 years, 6 months ago (2016-06-11 02:53:14 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-11 03:25:17 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-11 03:27:29 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9633249c6abb05f454533bf12b373e55f3020c09
Cr-Commit-Position: refs/heads/master@{#399359}

Powered by Google App Engine
This is Rietveld 408576698