fix skia + windows + gn

fix skia + windows + gn

The Skia Windows build for PDFium differs from the
Skia Chromium build in that it uses FreeType within
PDFium and Direct Write within Chromium. This allows
Chrome to match the UI of Windows, and allows
PDFium to use FreeType to measure and draw.

When PDFium was updated to use gn, the settings
from Chrome were used as the basis for the PDFium
settings. Subsequently, PDFium built with Skia on
Windows drew text incorrectly as it used FreeType to
look up the font glyphs and Direct Write to draw them.

This fixes the gn files, and also fixes an error that
crept into the now less-used gyp files.

R=dsinclair@chromium.org
BUG=

Committed: https://pdfium.googlesource.com/pdfium/+/72708b905309af930ca76a09746be5d09204cecd

[caryclark, 2016-06-10 19:52:45]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-10 19:52:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055353002/1

[caryclark, 2016-06-10 19:53:50]

Description was changed from

==========
fix skia + windows + gn

The Skia Windows build for PDFium differs from the
Skia Chromium build in that it uses FreeType within
PDFium and Direct Write within Chromium. This allows
Chrome to match the UI of Windows, and allows
PDFium to use FreeType to measure and draw.

When PDFium was updated to use gn, the settings
from Chrome were used as the basis for the PDFium
settings. Subsequently, PDFium built with Skia on
Windows drew text incorrectly as it used FreeType to
look up the font glyphs and Direct Write to draw them.

This fixes the gn files, and also fixes errors that have
crept into the now less-used gyp files.

Also, draw the text uses Skia pos text instead of
one character at a time.

R=dsinclair@chromium.org
BUG=
==========

to

==========
fix skia + windows + gn

The Skia Windows build for PDFium differs from the
Skia Chromium build in that it uses FreeType within
PDFium and Direct Write within Chromium. This allows
Chrome to match the UI of Windows, and allows
PDFium to use FreeType to measure and draw.

When PDFium was updated to use gn, the settings
from Chrome were used as the basis for the PDFium
settings. Subsequently, PDFium built with Skia on
Windows drew text incorrectly as it used FreeType to
look up the font glyphs and Direct Write to draw them.

This fixes the gn files, and also fixes errors that have
crept into the now less-used gyp files.

R=dsinclair@chromium.org
BUG=
==========

[caryclark, 2016-06-10 19:54:20]

Description was changed from

==========
fix skia + windows + gn

The Skia Windows build for PDFium differs from the
Skia Chromium build in that it uses FreeType within
PDFium and Direct Write within Chromium. This allows
Chrome to match the UI of Windows, and allows
PDFium to use FreeType to measure and draw.

When PDFium was updated to use gn, the settings
from Chrome were used as the basis for the PDFium
settings. Subsequently, PDFium built with Skia on
Windows drew text incorrectly as it used FreeType to
look up the font glyphs and Direct Write to draw them.

This fixes the gn files, and also fixes errors that have
crept into the now less-used gyp files.

R=dsinclair@chromium.org
BUG=
==========

to

==========
fix skia + windows + gn

The Skia Windows build for PDFium differs from the
Skia Chromium build in that it uses FreeType within
PDFium and Direct Write within Chromium. This allows
Chrome to match the UI of Windows, and allows
PDFium to use FreeType to measure and draw.

When PDFium was updated to use gn, the settings
from Chrome were used as the basis for the PDFium
settings. Subsequently, PDFium built with Skia on
Windows drew text incorrectly as it used FreeType to
look up the font glyphs and Direct Write to draw them.

This fixes the gn files, and also fixes an error that
crept into the now less-used gyp files.

R=dsinclair@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-06-10 20:07:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 20:07:01]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-06-13 12:52:11]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-06-13 12:52:11]

lgtm

[commit-bot: I haz the power, 2016-06-13 12:52:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055353002/1

[commit-bot: I haz the power, 2016-06-13 13:08:30]

Description was changed from

==========
fix skia + windows + gn

The Skia Windows build for PDFium differs from the
Skia Chromium build in that it uses FreeType within
PDFium and Direct Write within Chromium. This allows
Chrome to match the UI of Windows, and allows
PDFium to use FreeType to measure and draw.

When PDFium was updated to use gn, the settings
from Chrome were used as the basis for the PDFium
settings. Subsequently, PDFium built with Skia on
Windows drew text incorrectly as it used FreeType to
look up the font glyphs and Direct Write to draw them.

This fixes the gn files, and also fixes an error that
crept into the now less-used gyp files.

R=dsinclair@chromium.org
BUG=
==========

to

==========
fix skia + windows + gn

The Skia Windows build for PDFium differs from the
Skia Chromium build in that it uses FreeType within
PDFium and Direct Write within Chromium. This allows
Chrome to match the UI of Windows, and allows
PDFium to use FreeType to measure and draw.

When PDFium was updated to use gn, the settings
from Chrome were used as the basis for the PDFium
settings. Subsequently, PDFium built with Skia on
Windows drew text incorrectly as it used FreeType to
look up the font glyphs and Direct Write to draw them.

This fixes the gn files, and also fixes an error that
crept into the now less-used gyp files.

R=dsinclair@chromium.org
BUG=

Committed:
https://pdfium.googlesource.com/pdfium/+/72708b905309af930ca76a09746be5d09204...
==========

[commit-bot: I haz the power, 2016-06-13 13:08:31]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/72708b905309af930ca76a09746be5d09204...

[commit-bot: I haz the power, 2016-06-13 13:08:33]

CQ bit was unchecked