Courgette: Add static method QuickDetect() to optimize program detection.

courgette/program_detector_unittest.cc

Index: courgette/program_detector_unittest.cc
diff --git a/courgette/program_detector_unittest.cc b/courgette/program_detector_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a2ace5da3376a0ebff2f0933f0ca7e985a63b6ca
--- /dev/null
+++ b/courgette/program_detector_unittest.cc
@@ -0,0 +1,76 @@
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.

[huangs, 2016/06/13 18:30:28]

No "(c) "

[etiennep, 2016/06/14 21:16:38]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "courgette/program_detector.h"
+
+#include <string>
+
+#include "courgette/base_test_unittest.h"
+#include "courgette/courgette.h"
+#include "courgette/disassembler.h"
+#include "courgette/disassembler_elf_32_arm.h"
+#include "courgette/disassembler_elf_32_x86.h"
+#include "courgette/disassembler_win32_x64.h"
+#include "courgette/disassembler_win32_x86.h"
+
+namespace courgette {
+
+namespace {
+
+class ProgramDetectorTest : public BaseTest {
+ public:
+  void TestQuickDetect(const std::string& test_data,
+                       ExecutableType expected_type) const;
+  void TestDetectDisassembler(const std::string& test_data,
+                              ExecutableType expected_type) const;
+};
+
+void ProgramDetectorTest::TestQuickDetect(const std::string& test_data,
+                                          ExecutableType expected_type) const {
+  // QuickDetect should be positive only on the expected ExecutableType

[huangs, 2016/06/13 18:30:28]

NIT:
// QuickDetect() should return true only for the |expected_type|.

[etiennep, 2016/06/14 21:16:38]

Done.

+  EXPECT_EQ(
+      expected_type == EXE_WIN_32_X86,
+      DisassemblerWin32X86::QuickDetect(test_data.data(), test_data.size()));
+  EXPECT_EQ(
+      expected_type == EXE_WIN_32_X64,
+      DisassemblerWin32X64::QuickDetect(test_data.data(), test_data.size()));
+  EXPECT_EQ(
+      expected_type == EXE_ELF_32_X86,
+      DisassemblerElf32X86::QuickDetect(test_data.data(), test_data.size()));
+  EXPECT_EQ(
+      expected_type == EXE_ELF_32_ARM,
+      DisassemblerElf32ARM::QuickDetect(test_data.data(), test_data.size()));
+}
+
+void ProgramDetectorTest::TestDetectDisassembler(
+    const std::string& test_data,
+    ExecutableType expected_type) const {
+  ExecutableType detected_type;
+  size_t detected_length;

[huangs, 2016/06/13 18:30:28]

Initilize:
ExecutableType detected_type = EXE_UNKNOWN;
size_t detecte_length = 0;

[huangs, 2016/06/13 18:34:06]

Oops I mean 
size_t detected_length = 0;

[etiennep, 2016/06/14 21:16:37]

Done.

+  DetectExecutableType(test_data.data(), test_data.size(), &detected_type,
+                       &detected_length);
+  EXPECT_EQ(expected_type, detected_type);
+  EXPECT_EQ(test_data.size(), detected_length);
+}
+
+TEST_F(ProgramDetectorTest, All) {
+  std::string win32_x86 = FileContents("setup1.exe");
+  std::string win32_x64 = FileContents("chrome64_1.exe");
+  std::string elf_32 = FileContents("elf-32-1");
+  std::string elf_arm = FileContents("elf-armv7");
+
+  TestQuickDetect(win32_x86, EXE_WIN_32_X86);
+  TestQuickDetect(win32_x64, EXE_WIN_32_X64);
+  TestQuickDetect(elf_32, EXE_ELF_32_X86);
+  TestQuickDetect(elf_arm, EXE_ELF_32_ARM);
+
+  TestDetectDisassembler(win32_x86, EXE_WIN_32_X86);
+  TestDetectDisassembler(win32_x64, EXE_WIN_32_X64);
+  TestDetectDisassembler(elf_32, EXE_ELF_32_X86);
+  TestDetectDisassembler(elf_arm, EXE_ELF_32_ARM);
+}
+
+}  // namespace
+
+}  // namespace courgette