Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: courgette/disassembler_win32_x86.h

Issue 2055343002: Courgette: Add static method QuickDetect() to optimize program detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit cleanup Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: courgette/disassembler_win32_x86.h
diff --git a/courgette/disassembler_win32_x86.h b/courgette/disassembler_win32_x86.h
index 6602f37ea957c33a6d538f0fb18d676948908570..f240980489fb4a16523a84ca87a1758137dfbc35 100644
--- a/courgette/disassembler_win32_x86.h
+++ b/courgette/disassembler_win32_x86.h
@@ -19,7 +19,13 @@ class AssemblyProgram;
class DisassemblerWin32X86 : public DisassemblerWin32 {
public:
- DisassemblerWin32X86(const void* start, size_t length);
+ // Returns 'true' if an valid executable is detected using only quick checks.
huangs 2016/06/17 15:21:57 NIT: true does not need '' NIT: *a* valid executab
+ static bool QuickDetect(const uint8_t* start, size_t length) {
+ return DisassemblerWin32::QuickDetect(start, length,
+ kImageNtOptionalHdr32Magic);
+ }
+
+ DisassemblerWin32X86(const uint8_t* start, size_t length);
~DisassemblerWin32X86() override = default;
// Disassembler interfaces.

Powered by Google App Engine
This is Rietveld 408576698