Chromium Code Reviews| Index: courgette/disassembler_win32.h |
| diff --git a/courgette/disassembler_win32.h b/courgette/disassembler_win32.h |
| index 42dc2fef3ada8367c6871a1fdf49c9850a68c326..549c0fa6052e1f2f0f646edc65355d23bfb16469 100644 |
| --- a/courgette/disassembler_win32.h |
| +++ b/courgette/disassembler_win32.h |
| @@ -49,12 +49,17 @@ class DisassemblerWin32 : public Disassembler { |
| static std::string SectionName(const Section* section); |
| protected: |
| + // Returns 'true' if an valid executable is detected using only quick checks. |
| + // Derived classes should inject |magic| corresponding to their architecture, |
| + // which will be checked against the detected one. |
|
huangs
2016/06/15 00:13:05
NIT: Extra space before "which".
etiennep
2016/06/15 20:38:06
Done.
|
| + static bool QuickDetect(const uint8_t* start, size_t length, uint16_t magic); |
| + |
| // Disassembler interfaces. |
| RvaVisitor* CreateAbs32TargetRvaVisitor() override; |
| RvaVisitor* CreateRel32TargetRvaVisitor() override; |
| void RemoveUnusedRel32Locations(AssemblyProgram* program) override; |
| - DisassemblerWin32(const void* start, size_t length); |
| + DisassemblerWin32(const uint8_t* start, size_t length); |
| CheckBool ParseFile(AssemblyProgram* target) WARN_UNUSED_RESULT; |
| bool ParseAbs32Relocs(); |