Chromium Code Reviews| Index: courgette/disassembler_elf_32.h |
| diff --git a/courgette/disassembler_elf_32.h b/courgette/disassembler_elf_32.h |
| index 6bcf1b888b80cd80f3529a3f3900d3f405bee630..6d9ee1d1ead3e3f9848e3fb9280985919fabd4cb 100644 |
| --- a/courgette/disassembler_elf_32.h |
| +++ b/courgette/disassembler_elf_32.h |
| @@ -94,7 +94,7 @@ class DisassemblerElf32 : public Disassembler { |
| }; |
| public: |
| - DisassemblerElf32(const void* start, size_t length); |
| + DisassemblerElf32(const uint8_t* start, size_t length); |
| ~DisassemblerElf32() override { } |
| @@ -121,6 +121,13 @@ class DisassemblerElf32 : public Disassembler { |
| } |
| protected: |
| + // Returns 'true' if an valid executable is detected using only quick checks. |
| + // Derived classes should inject |elf_em| corresponding to their architecture, |
| + // which will be checked against the detected one. |
|
huangs
2016/06/15 00:13:04
NIT: Extra space before "which".
etiennep
2016/06/15 20:38:06
Done.
|
| + static bool QuickDetect(const uint8_t* start, |
| + size_t length, |
| + e_machine_values elf_em); |
| + |
| bool UpdateLength(); |
| // Misc Section Helpers |