Courgette: Add static method QuickDetect() to optimize program detection.

courgette/disassembler_win32.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "courgette/disassembler_win32.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 635 matching lines @@
     directory->address_ = rva;
     directory->size_ = static_cast<uint32_t>(size);
     return true;
   } else {
     directory->address_ = 0;
     directory->size_ = 0;
     return true;
   }
 }
 
+bool DisassemblerWin32::QuickDetects(const uint8_t* start,

[huangs, 2016/06/10 21:10:22]

Move to line 341 for consistent ordering with header.

[etiennep, 2016/06/13 17:50:21]

Done.

+                                     size_t length,
+                                     uint16_t magic) {
+  if (length < kOffsetOfFileAddressOfNewExeHeader + 4 /* size */)
+    return false;
+
+  // Have 'MZ' magic for a DOS header?
+  if (start[0] != 'M' || start[1] != 'Z')
+    return false;
+
+  FileOffset file_offset = static_cast<FileOffset>(
+      ReadU32(start, kOffsetOfFileAddressOfNewExeHeader));
+  if (file_offset >= length)
+    return false;
+  const uint8_t* const pe_header = start + file_offset;
+  const size_t kMinPEHeaderSize = 4 /*signature*/ + kSizeOfCoffHeader;
+  if (pe_header <= start || pe_header >= start + length - kMinPEHeaderSize)

[huangs, 2016/06/10 21:10:22]

NIT: I'd prefer
pe_header + kMinPEHeaderSize >= start + length

[etiennep, 2016/06/13 17:50:21]

Done.

+    return false;
+  if (file_offset % 8 != 0)

[huangs, 2016/06/10 21:10:22]

Can combine this condition via || with "file_offset >= length" before.

[etiennep, 2016/06/13 17:50:21]

Done.

+    return false;
+
+  const uint8_t* optional_header = pe_header + 4 + kSizeOfCoffHeader;
+
+  // Check we can read the magic.
+  if (optional_header + 2 >= start + length)
+    return false;
+  if (magic != ReadU16(optional_header, 0))
+    return false;
+
+  return true;
+}
+
 }  // namespace courgette