Remove -fsanitize-coverage=edge from UBSanVptr ToT bot.

Remove -fsanitize-coverage=edge from UBSanVptr ToT bot.

It's not used anywere, from what I can tell.
This should fix the bot:https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxUBSanVptr/

BUG=618534

[krasin, 2016-06-10 18:26:51]

Description was changed from

==========
Remove -fsanitize-coverage=edge from UBSanVptr ToT bot.

It's not used anywere, from what I can tell.

BUG=618534
==========

to

==========
Remove -fsanitize-coverage=edge from UBSanVptr ToT bot.

It's not used anywere, from what I can tell.
This should fix the
bot:https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxUBSanVptr/

BUG=618534
==========

[krasin, 2016-06-10 18:26:51]

krasin@google.com changed reviewers:
+ dpranke@chromium.org

[Nico, 2016-06-13 15:29:41]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-06-13 15:29:42]

Hm, from the bug it sounds like in gyp we build with this set, and then unset it
for just mesa.

If we really don't need edge coverage for ubsan bots, then I think you need to
remove it from 'UBSan vptr Release' too.

The clusterfuzz bots (say CFI Release CF) do need edge coverage for CF, right?
(not actually sure) If so, will the CFI bots have issues with this? (I don't
remember if they're already on gn)

[krasin, 2016-06-13 15:31:35]

On 2016/06/13 15:29:42, Nico (traveling...slow) wrote:
> Hm, from the bug it sounds like in gyp we build with this set, and then unset
it
> for just mesa.
> 
> If we really don't need edge coverage for ubsan bots, then I think you need to
> remove it from 'UBSan vptr Release' too.
> 
> The clusterfuzz bots (say CFI Release CF) do need edge coverage for CF, right?
> (not actually sure) If so, will the CFI bots have issues with this? (I don't
> remember if they're already on gn)

I admit, there's a chance that I am missing something, but to the best of my
knowledge, the coverage is only useful for libfuzzer, which is not what we do
here.

[krasin, 2016-06-13 15:32:44]

I am also unsure which bot do you mean by 'UBSan vptr Release'. I could not find
it, sorry.

[Nico, 2016-06-13 15:40:23]

https://codereview.chromium.org/2055323002/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2055323002/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:343: 'UBSan vptr Release':
'gyp_ubsan_vptr_edge_release_bot',
this guy

[Nico, 2016-06-13 15:41:45]

https://codereview.chromium.org/2055323002/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2055323002/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:343: 'UBSan vptr Release':
'gyp_ubsan_vptr_edge_release_bot',
On 2016/06/13 15:40:23, Nico (traveling...slow) wrote:
> this guy

Looks like this bot does upload to clusterfuzz:
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_...

Might want to ask the clusterfuzz folks if they need the edge coverage – many of
the CF bots do build with it as far as I can tell.

[Dirk Pranke, 2016-06-13 16:09:34]

MB's presubmit checks will enforce that every config and mixin is used
*somewhere*, so it shouldn't be hard to figure out where the flags are used.

I have no particular opinion on this change; that's between you, thakis@, and
the CF folks. lgtm either way as long as the presubmit checks pass.

[krasin, 2016-06-13 16:11:21]

It seems that ClusterFuzz folks actually use this. Withdrawing the CL, and sorry
for the noise.