Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2055283002: kitchen: CURRENT_TIMESTAMP support (Closed)

Created:
4 years, 6 months ago by nodir
Modified:
4 years, 6 months ago
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

kitchen: CURRENT_TIMESTAMP support Add -timestamps flag: if set, emit CURRENT_TIMESTAMP and pass --timestamps to recipes.py Also fix bug in cook: final annotations were not printed in case of failure. R=martiniss@chromium.org BUG=613584 Committed: https://github.com/luci/luci-go/commit/16134c57b96067a549a014e8c3ae3addf390285c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M client/cmd/kitchen/cook.go View 8 chunks +28 lines, -2 lines 0 comments Download
M client/cmd/kitchen/recipe.go View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
nodir
PTAL Tested locally
4 years, 6 months ago (2016-06-10 16:59:31 UTC) #1
martiniss
Is kitchen still being used? I thought that we replaced that with remote_run in the ...
4 years, 6 months ago (2016-06-10 18:54:37 UTC) #3
nodir
yes, I will replace kitchen with remote_run. Currently too many things change at the same ...
4 years, 6 months ago (2016-06-10 20:06:21 UTC) #4
Paweł Hajdan Jr.
LGTM
4 years, 6 months ago (2016-06-13 15:38:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055283002/1
4 years, 6 months ago (2016-06-13 16:13:25 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 16:20:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/16134c57b96067a549a014e8c3ae3addf390285c

Powered by Google App Engine
This is Rietveld 408576698