Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Issue 2055273004: Remove unused variables, ash/ edition. (Closed)

Created:
4 years, 6 months ago by Peter Kasting
Modified:
4 years, 6 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused variables, ash/ edition. These were exposed while trying to make various geometry classes constexpr. BUG=none TEST=none Committed: https://crrev.com/7da13a533284fd918f10737750e5281b76821644 Cr-Commit-Position: refs/heads/master@{#399557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -51 lines) Patch
M ash/common/wm/dock/docked_window_layout_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/mirror_window_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/sysui/sysui_application.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/touch/touch_transformer_controller.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/utility/screenshot_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/lock_window_state.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 5 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Peter Kasting
4 years, 6 months ago (2016-06-10 21:18:04 UTC) #2
Peter Kasting
Friendly ping
4 years, 6 months ago (2016-06-13 20:20:27 UTC) #3
Peter Kasting
Oh, looks like derat is OOO. Changing to jamescook.
4 years, 6 months ago (2016-06-13 20:47:04 UTC) #5
James Cook
LGTM. Thanks for cleaning these up.
4 years, 6 months ago (2016-06-13 20:58:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055273004/1
4 years, 6 months ago (2016-06-13 21:06:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 21:51:28 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 21:51:42 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 21:54:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7da13a533284fd918f10737750e5281b76821644
Cr-Commit-Position: refs/heads/master@{#399557}

Powered by Google App Engine
This is Rietveld 408576698