Update message for Gerrit git cl --no-squash users.

Update message for Gerrit git cl --no-squash users.

R=andybons@chromium.org
BUG=611892
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/26f3e4eecb09d2608b1ac304de9d5d3c68de67ce

[tandrii(chromium), 2016-06-10 14:30:40]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-10 14:30:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055233002/1

[tandrii(chromium), 2016-06-10 14:31:00]

Description was changed from

==========
Update message for Gerrit git cl --no-squash users.

R=andybons@chromium.org
BUG=611892

Change-Id: I6166a9adc717748d984a5959697cd865421b6b62
==========

to

==========
Update message for Gerrit git cl --no-squash users.

R=andybons@chromium.org
BUG=611892
==========

[commit-bot: I haz the power, 2016-06-10 14:34:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 14:34:20]

Dry run: This issue passed the CQ dry run.

[Bons, 2016-06-10 15:02:07]

lgtm

https://codereview.chromium.org/2055233002/diff/1/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://codereview.chromium.org/2055233002/diff/1/tests/git_cl_test.py#newcod...
tests/git_cl_test.py:768: ((['git', 'config', '--bool',
'gerrit.squash-uploads'],), 'false'),
Why the duplicate here? I must be missing something.

[tandrii(chromium), 2016-06-10 15:33:03]

https://codereview.chromium.org/2055233002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2055233002/diff/1/git_cl.py#newcode2354
git_cl.py:2354: options.squash = ((settings.GetSquashGerritUploads() or
options.squash) and
this is the other point at which it's called.
Yes, redundant. 
But, as you can see above, my condition is very specific - i really want to
detect that a user hasn't set the option to false, but GetSquashGerritUploads()
would return default (false now, true later).

https://codereview.chromium.org/2055233002/diff/1/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://codereview.chromium.org/2055233002/diff/1/tests/git_cl_test.py#newcod...
tests/git_cl_test.py:768: ((['git', 'config', '--bool',
'gerrit.squash-uploads'],), 'false'),
On 2016/06/10 15:02:07, Bons wrote:
> Why the duplicate here? I must be missing something.

well, it's an extra call I've added. Actually, the one I added is first one in
this list. The second comes from line 2354.

[tandrii(chromium), 2016-06-10 15:33:26]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-06-10 15:33:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055233002/1

[Bons, 2016-06-10 15:36:00]

On 2016/06/10 at 15:33:03, tandrii wrote:
> https://codereview.chromium.org/2055233002/diff/1/git_cl.py
> File git_cl.py (right):
> 
> https://codereview.chromium.org/2055233002/diff/1/git_cl.py#newcode2354
> git_cl.py:2354: options.squash = ((settings.GetSquashGerritUploads() or
options.squash) and
> this is the other point at which it's called.
> Yes, redundant. 
> But, as you can see above, my condition is very specific - i really want to
detect that a user hasn't set the option to false, but GetSquashGerritUploads()
would return default (false now, true later).
> 
> https://codereview.chromium.org/2055233002/diff/1/tests/git_cl_test.py
> File tests/git_cl_test.py (right):
> 
>
https://codereview.chromium.org/2055233002/diff/1/tests/git_cl_test.py#newcod...
> tests/git_cl_test.py:768: ((['git', 'config', '--bool',
'gerrit.squash-uploads'],), 'false'),
> On 2016/06/10 15:02:07, Bons wrote:
> > Why the duplicate here? I must be missing something.
> 
> well, it's an extra call I've added. Actually, the one I added is first one in
this list. The second comes from line 2354.

Cool. Just wanted to make sure it wasn’t a mistake :)

[commit-bot: I haz the power, 2016-06-10 15:37:07]

Description was changed from

==========
Update message for Gerrit git cl --no-squash users.

R=andybons@chromium.org
BUG=611892
==========

to

==========
Update message for Gerrit git cl --no-squash users.

R=andybons@chromium.org
BUG=611892

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/26f3e4eecb09d2...
==========

[commit-bot: I haz the power, 2016-06-10 15:37:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/26f3e4eecb09d2...