Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2055223002: Define LEAN_AND_MEAN and NOMINMAX for all windows builds (Closed)

Created:
4 years, 6 months ago by egdaniel
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Define LEAN_AND_MEAN and NOMINMAX for all windows builds BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055223002 Committed: https://skia.googlesource.com/skia/+/5dfe7bbcfda3586142dd724fb1c715b4a549f8ee

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M gyp/common_conditions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gpu/gl/win/CreatePlatformGLTestContext_win.cpp View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 9 (4 generated)
egdaniel
4 years, 6 months ago (2016-06-10 13:13:47 UTC) #3
jvanverth1
lgtm
4 years, 6 months ago (2016-06-10 13:22:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055223002/1
4 years, 6 months ago (2016-06-10 13:28:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/5dfe7bbcfda3586142dd724fb1c715b4a549f8ee
4 years, 6 months ago (2016-06-10 13:42:49 UTC) #8
bungeman-skia
4 years, 6 months ago (2016-06-10 15:25:49 UTC) #9
Message was sent while issue was closed. 
lgtm, with silly nit

https://codereview.chromium.org/2055223002/diff/1/tools/gpu/gl/win/CreatePlat...
File tools/gpu/gl/win/CreatePlatformGLTestContext_win.cpp (right):

https://codereview.chromium.org/2055223002/diff/1/tools/gpu/gl/win/CreatePlat...
tools/gpu/gl/win/CreatePlatformGLTestContext_win.cpp:15: #include <windows.h>
heh, do we really include windows.h twice here?

Powered by Google App Engine
This is Rietveld 408576698