Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: include/v8.h

Issue 2055203002: [snapshot] support multiple contexts in the same snapshot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@sinkmember
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | test/cctest/test-serialize.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index a15a33c60cb95efffb9c3858ff47ce63b2758ce7..ab1708f8fe3ad9b9c153bd9cdd94d5692ef3a361 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -6792,8 +6792,9 @@ class SnapshotCreator {
/**
* Add a context to be included in the snapshot blob.
+ * \returns the index of the context in the snapshot blob.
*/
- void AddContext(Local<Context> context);
+ int AddContext(Local<Context> context);
jochen (gone - plz use gerrit) 2016/06/13 15:24:19 size_t?
Yang 2016/06/14 11:45:30 This is supposed to mirror the argument of Context
/**
* Created a snapshot data blob.
@@ -7097,7 +7098,8 @@ class V8_EXPORT Context {
static Local<Context> New(
Isolate* isolate, ExtensionConfiguration* extensions = NULL,
Local<ObjectTemplate> global_template = Local<ObjectTemplate>(),
- Local<Value> global_object = Local<Value>());
+ Local<Value> global_object = Local<Value>(),
+ int context_snapshot_index = 0);
vogelheim 2016/06/13 16:20:20 The argument context_snapshot_index has no \param
Yang 2016/06/14 11:45:30 0 as default reflects the current behavior. To cre
/**
* Sets the security token for the context. To access an object in
« no previous file with comments | « no previous file | src/api.cc » ('j') | test/cctest/test-serialize.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698