Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2055103002: remove redundant CFX_Matrix* cast in one-d barcode (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

remove redundant CFX_Matrix* cast in one-d barcode Committed: https://pdfium.googlesource.com/pdfium/+/855665d4889853f8ac71519de8ff004dba8eb056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -59 lines) Patch
M xfa/fxbarcode/oned/BC_OneDimWriter.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedEAN13Writer.cpp View 6 chunks +12 lines, -18 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedEAN8Writer.cpp View 3 chunks +8 lines, -12 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedUPCAWriter.cpp View 8 chunks +16 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, for review.
4 years, 6 months ago (2016-06-09 23:58:03 UTC) #2
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-10 01:16:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055103002/1
4 years, 6 months ago (2016-06-10 01:16:34 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 02:19:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/855665d4889853f8ac71519de8ff004dba8e...

Powered by Google App Engine
This is Rietveld 408576698