components/cronet/android/api/src/org/chromium/net/CronetEngine.java - Issue 2055083002: [Cronet] Fix CronetFixedModeOutputStream to not write more bytes than specified

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/api/src/org/chromium/net/CronetEngine.java

Issue 2055083002: [Cronet] Fix CronetFixedModeOutputStream to not write more bytes than specified (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add @VisibleForTesting Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/BUILD.gn ('k') | components/cronet/android/java/src/org/chromium/net/urlconnection/CronetFixedModeOutputStream.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetFixedModeOutputStreamTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/api/src/org/chromium/net/CronetEngine.java

diff --git a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java

index f30991ac3c7ae2223aaaeabfa683902ab575467f..b9f717fe5bca62a7c24d4369b032888a843141d9 100644

--- a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java

+++ b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java

@@ -9,6 +9,7 @@ import android.content.Context;

import android.net.http.HttpResponseCache;

import android.support.annotation.IntDef;

import android.support.annotation.Nullable;

+import android.support.annotation.VisibleForTesting;

import android.util.Log;

import java.io.File;

@@ -591,7 +592,8 @@ public abstract class CronetEngine {

* @param mockCertVerifier pointer to native MockCertVerifier.

* @return the builder to facilitate chaining.

pauljensen 2016/06/14 12:50:31 needs @hide

xunjieli 2016/06/14 13:12:48 Done.

- Builder setMockCertVerifierForTesting(long mockCertVerifier) {

+ @VisibleForTesting

+ public Builder setMockCertVerifierForTesting(long mockCertVerifier) {

mMockCertVerifier = mockCertVerifier;

return this;

}