[Cronet] Fix CronetFixedModeOutputStream to not write more bytes than specified

components/cronet/android/test/javatests/src/org/chromium/net/QuicUploadTest.java

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.net;

[pauljensen, 2016/06/13 12:22:13]

I think this should be moved to the urlconnection package and directory

[xunjieli, 2016/06/13 14:23:23]

Done.

+
+import android.test.suitebuilder.annotation.SmallTest;
+
+import org.chromium.base.test.util.Feature;
+import org.json.JSONObject;
+
+import java.io.OutputStream;
+import java.net.HttpURLConnection;
+import java.net.URL;
+
+/**
+ * Tests HttpURLConnection upload using QUIC.
+ */
+@SuppressWarnings("deprecation")
+public class QuicUploadTest extends CronetTestBase {
+    private CronetTestFramework mTestFramework;
+
+    @Override
+    protected void setUp() throws Exception {
+        super.setUp();
+        // Load library first to create MockCertVerifier.
+        System.loadLibrary("cronet_tests");
+        CronetEngine.Builder builder = new CronetEngine.Builder(getContext());
+
+        QuicTestServer.startQuicTestServer(getContext());
+
+        builder.enableQUIC(true);
+        JSONObject quicParams = new JSONObject().put("host_whitelist", "test.example.com");

[pauljensen, 2016/06/13 12:22:13]

use QuicTestServer.getServerHost()

[xunjieli, 2016/06/13 14:23:23]

Done.

+        JSONObject experimentalOptions = new JSONObject().put("QUIC", quicParams);
+        builder.setExperimentalOptions(experimentalOptions.toString());
+
+        builder.addQuicHint(QuicTestServer.getServerHost(), QuicTestServer.getServerPort(),
+                QuicTestServer.getServerPort());
+
+        builder.setMockCertVerifierForTesting(QuicTestServer.createMockCertVerifier());
+
+        mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, builder);
+        registerHostResolver(mTestFramework);
+    }
+
+    @SmallTest
+    @Feature({"Cronet"})
+    @OnlyRunNativeCronet
+    // Regression testing for crbug.com/618872.
+    public void testOneMassiveWrite() throws Exception {
+        String path = "/simple.txt";
+        URL url = new URL(QuicTestServer.getServerURL() + path);
+        HttpURLConnection connection =
+                (HttpURLConnection) mTestFramework.mCronetEngine.openConnection(url);
+        connection.setDoOutput(true);
+        connection.setRequestMethod("POST");
+        byte[] largeData = new byte[195055];
+        for (int i = 0; i < largeData.length; i++) {
+            largeData[i] = 97;
+        }

[pauljensen, 2016/06/13 12:22:13]

use Arrays.fill(largeData, 97)

[xunjieli, 2016/06/13 14:23:23]

Done.

+        connection.setFixedLengthStreamingMode(largeData.length);
+        OutputStream out = connection.getOutputStream();
+        // Write everything at one go, so the data is larger than the buffer
+        // used in CronetFixedModeOutputStream.
+        out.write(largeData);
+        assertEquals(200, connection.getResponseCode());
+        connection.disconnect();
+    }
+}