Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2055063002: Plumb iteration info (Closed)

Created:
4 years, 6 months ago by benjhayden
Modified:
4 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb iteration info See also catapult-side: https://codereview.chromium.org/2055043002 BUG=catapult:#2405

Patch Set 1 #

Total comments: 2

Patch Set 2 : make GetExtraIterationInfo call super().GetExtraIterationInfo() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M tools/perf/core/perf_benchmark.py View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
benjhayden
PTAL
4 years, 6 months ago (2016-06-09 23:07:24 UTC) #3
sullivan
4 years, 6 months ago (2016-06-10 16:56:57 UTC) #5
We need to start by sorting out what goes in the recipe vs telemetry. I feel
like buildbot-specific stuff is better in the recipe, but I could be wrong.
Dave, Ned, opinions?

For background, the current recipe annotates JSON here:
https://cs.chromium.org/chromium/build/scripts/slave/results_dashboard.py?l=181

You'll notice immediately this code is pretty ugly, and later on you'll notice
that the recipes aren't factored well (for what happens on bisect, waterfall,
android, fyi, trybots, etc). Dave has been working on this and will likely have
input.

https://codereview.chromium.org/2055063002/diff/1/tools/perf/core/perf_benchm...
File tools/perf/core/perf_benchmark.py (right):

https://codereview.chromium.org/2055063002/diff/1/tools/perf/core/perf_benchm...
tools/perf/core/perf_benchmark.py:32: info['botName'] = botName
Do we need the bot name? The dashboard automatically pulls it from the test
path.

https://codereview.chromium.org/2055063002/diff/1/tools/perf/core/perf_benchm...
tools/perf/core/perf_benchmark.py:41: 
These are pulled in via the recipe already.

Powered by Google App Engine
This is Rietveld 408576698