[BlobAsync] Disk support for blob storage

storage/common/blob_storage/blob_storage_constants.cc

Index: storage/common/blob_storage/blob_storage_constants.cc
diff --git a/storage/common/blob_storage/blob_storage_constants.cc b/storage/common/blob_storage/blob_storage_constants.cc
new file mode 100644
index 0000000000000000000000000000000000000000..805eaaa26093cfe4dda6f90f47fcbe31a1e8ecb1
--- /dev/null
+++ b/storage/common/blob_storage/blob_storage_constants.cc
@@ -0,0 +1,33 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "storage/common/blob_storage/blob_storage_constants.h"
+
+namespace storage {
+
+bool BlobStatusIsError(BlobStatus status) {
+  return static_cast<int>(status) < static_cast<int>(BlobStatus::DONE);
+}
+
+bool BlobStatusIsBadIPC(BlobStatus status) {
+  return status == BlobStatus::INVALID_CONSTRUCTION_ARGUMENTS;

[kinuko, 2016/07/17 16:15:47]

Hmm this feels a bit weird... it should be at least commented in the enum
definition

Is 'invalid construction arguments' is the only error case for Bad IPC?

INVALID_CONSTRUCTION_ARGUMENTS or just INVALID_ARGUMENTS?

[dmurph, 2016/07/19 02:26:28]

Well, invalid arguments, should I remove construction?

+}
+
+bool BlobStatusIsPending(BlobStatus status) {
+  switch (status) {
+    case BlobStatus::INVALID_CONSTRUCTION_ARGUMENTS:
+    case BlobStatus::OUT_OF_MEMORY:
+    case BlobStatus::FILE_WRITE_FAILED:
+    case BlobStatus::SOURCE_DIED_IN_TRANSIT:
+    case BlobStatus::BLOB_DEREFERENCED_WHILE_BUILDING:
+    case BlobStatus::REFERENCED_BLOB_BROKEN:
+    case BlobStatus::DONE:
+      return false;
+    case BlobStatus::PENDING_MEMORY_QUOTA:
+    case BlobStatus::PENDING_DATA_POPULATION:
+      return true;
+  }

[kinuko, 2016/07/17 16:15:47]

NOTREACHED();

[dmurph, 2016/07/19 02:26:28]

Done.

+}
+
+}  // namespace storage