Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: storage/browser/blob/shareable_blob_data_item.cc

Issue 2055053003: [BlobAsync] Disk support for blob storage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Finished comments, added new pending enum state Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/blob/shareable_blob_data_item.cc
diff --git a/storage/browser/blob/shareable_blob_data_item.cc b/storage/browser/blob/shareable_blob_data_item.cc
index 40aaf9c7e10d29d40acbc73798f67f6c16030b4d..3602106e378c6e6ec79a09c8d6a5a4e3a93db62b 100644
--- a/storage/browser/blob/shareable_blob_data_item.cc
+++ b/storage/browser/blob/shareable_blob_data_item.cc
@@ -7,20 +7,46 @@
#include "storage/browser/blob/blob_data_item.h"
namespace storage {
+namespace {
-ShareableBlobDataItem::ShareableBlobDataItem(
- const std::string& blob_uuid,
- const scoped_refptr<BlobDataItem>& item)
- : item_(item) {
+uint64_t GetAndIncrementItemId() {
+ static uint64_t sNextItemId = 0;
+ return sNextItemId++;
+}
+
+} // namespace
+
+ShareableBlobDataItem::ShareableBlobDataItem(scoped_refptr<BlobDataItem> item)
+ : item_id_(GetAndIncrementItemId()), item_(std::move(item)) {
DCHECK_NE(item_->type(), DataElement::TYPE_BLOB);
- referencing_blobs_.insert(blob_uuid);
}
ShareableBlobDataItem::~ShareableBlobDataItem() {
}
-const scoped_refptr<BlobDataItem>& ShareableBlobDataItem::item() {
+const scoped_refptr<BlobDataItem>& ShareableBlobDataItem::item() const {
return item_;
}
+void PrintTo(const ShareableBlobDataItem& x, ::std::ostream* os) {
+ *os << "<ShareableBlobDataItem>{ item_id: " << x.item_id_ << ", item: ";
+ PrintTo(*x.item_, os);
+ *os << ", referencing_blobs: [";
+ for (const std::string& uuid : x.referencing_blobs_) {
+ *os << uuid << ", ";
+ }
+ *os << "]}";
+}
+
+bool operator==(const ShareableBlobDataItem& a,
+ const ShareableBlobDataItem& b) {
+ return a.item_id() == b.item_id() && *a.item() == *b.item() &&
+ a.referencing_blobs() == b.referencing_blobs();
+}
+
+bool operator!=(const ShareableBlobDataItem& a,
+ const ShareableBlobDataItem& b) {
+ return !(a == b);
+}
+
} // namespace storage

Powered by Google App Engine
This is Rietveld 408576698