[BlobAsync] Disk support for blob storage

storage/browser/blob/blob_data_handle.cc

Index: storage/browser/blob/blob_data_handle.cc
diff --git a/storage/browser/blob/blob_data_handle.cc b/storage/browser/blob/blob_data_handle.cc
index 55e63a1b620697add3368bf82cd0537387de0eb5..1d296ab8b6e12e09c5ed86f83c19f8df2e8878ae 100644
--- a/storage/browser/blob/blob_data_handle.cc
+++ b/storage/browser/blob/blob_data_handle.cc
@@ -26,8 +26,6 @@
 #include "url/gurl.h"
 
 namespace storage {
-using BlobState = BlobStorageRegistry::BlobState;
-
 namespace {
 
 class FileStreamReaderProviderImpl
@@ -67,10 +65,12 @@ BlobDataHandle::BlobDataHandleShared::BlobDataHandleShared(
     const std::string& uuid,
     const std::string& content_type,
     const std::string& content_disposition,
+    uint64_t size,
     BlobStorageContext* context)
     : uuid_(uuid),
       content_type_(content_type),
       content_disposition_(content_disposition),
+      size_(size),
       context_(context->AsWeakPtr()) {
   context_->IncrementBlobRefCount(uuid);
 }
@@ -92,12 +92,14 @@ BlobDataHandle::BlobDataHandleShared::~BlobDataHandleShared() {
 BlobDataHandle::BlobDataHandle(const std::string& uuid,
                                const std::string& content_type,
                                const std::string& content_disposition,
+                               uint64_t size,
                                BlobStorageContext* context,
                                base::SequencedTaskRunner* io_task_runner)
     : io_task_runner_(io_task_runner),
       shared_(new BlobDataHandleShared(uuid,
                                        content_type,
                                        content_disposition,
+                                       size,
                                        context)) {
   DCHECK(io_task_runner_.get());
   DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
@@ -121,21 +123,25 @@ bool BlobDataHandle::IsBeingBuilt() const {
   DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
   if (!shared_->context_)
     return false;
-  return shared_->context_->IsBeingBuilt(shared_->uuid_);
+  return shared_->context_->GetBlobStatus(shared_->uuid_) ==

[Marijn Kruisselbrink, 2016/07/12 21:33:06]

nit: could just write this as GetBlobStatus() == BlobStatus::PENDING;

[dmurph, 2016/07/14 01:04:31]

Done.

+         BlobStatus::PENDING;
 }
 
 bool BlobDataHandle::IsBroken() const {
   DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
   if (!shared_->context_)
     return true;
-  return shared_->context_->IsBroken(shared_->uuid_);
+  return BlobStatusIsError(shared_->context_->GetBlobStatus(shared_->uuid_));

[Marijn Kruisselbrink, 2016/07/12 21:33:06]

nit: here too, could just use BlobDataHandle::GetBlobStatus to simplify the code
a tiniest bit

[dmurph, 2016/07/14 01:04:31]

Done.

+}
+
+BlobStatus BlobDataHandle::GetBlobStatus() const {
+  return shared_->context_->GetBlobStatus(shared_->uuid_);
 }
 
-void BlobDataHandle::RunOnConstructionComplete(
-    const BlobConstructedCallback& done) {
+void BlobDataHandle::RunOnConstructionComplete(const BlobStatusCallback& done) {
   DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
   if (!shared_->context_.get()) {
-    done.Run(false, IPCBlobCreationCancelCode::UNKNOWN);
+    done.Run(BlobStatus::INVALID_CONSTRUCTION_ARGUMENTS);
     return;
   }
   shared_->context_->RunOnConstructionComplete(shared_->uuid_, done);
@@ -160,4 +166,8 @@ const std::string& BlobDataHandle::content_disposition() const {
   return shared_->content_disposition_;
 }
 
+uint64_t BlobDataHandle::size() const {
+  return shared_->size_;
+}
+
 }  // namespace storage