telemetry/telemetry/page/__init__.py - Issue 2055043002: Plumb IterationInfo from telemetry to a diagnostic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/page/init.py

Issue 2055043002: Plumb IterationInfo from telemetry to a diagnostic (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: IterationInfo python class Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/page/__init__.py

diff --git a/telemetry/telemetry/page/__init__.py b/telemetry/telemetry/page/__init__.py

index 279a09ed5d3fbedfef466958171c9df13b763db5..92067671635296ba1a658030d71bbdb7bc1d61df 100644

--- a/telemetry/telemetry/page/__init__.py

+++ b/telemetry/telemetry/page/__init__.py

@@ -212,7 +212,7 @@ class Page(story.Story):

def display_name(self):

if self.name:

return self.name

- if not self.is_file:

+ if self.page_set is None or not self.is_file:

return self.url

all_urls = [p.url.rstrip('/') for p in self.page_set if p.is_file]

common_prefix = os.path.dirname(os.path.commonprefix(all_urls))