Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2055023003: Type-erase SkAutoMutexAcquire and SkAutoExclusive. (Closed)

Created:
4 years, 6 months ago by mtklein_C
Modified:
4 years, 6 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Type-erase SkAutoMutexAcquire and SkAutoExclusive. This is purely for convenience, to not need to write the lock type in the guard anymore. This should all inline away. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055023003 Committed: https://skia.googlesource.com/skia/+/f10637f2795b147751ef413237389d230b869360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -60 lines) Patch
M dm/DM.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M include/private/SkMutex.h View 1 chunk +27 lines, -37 lines 0 comments Download
M src/core/SkGlyphCache.cpp View 6 chunks +6 lines, -8 lines 0 comments Download
M src/ports/SkScalerContext_win_dw.cpp View 9 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055023003/1
4 years, 6 months ago (2016-06-10 20:08:22 UTC) #3
mtklein_C
4 years, 6 months ago (2016-06-10 20:18:55 UTC) #5
bungeman-skia
lgtm
4 years, 6 months ago (2016-06-10 20:23:17 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-10 20:27:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055023003/1
4 years, 6 months ago (2016-06-10 20:55:43 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 20:56:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f10637f2795b147751ef413237389d230b869360

Powered by Google App Engine
This is Rietveld 408576698