third_party/WebKit/Source/core/css/fullscreenAndroid.css - Issue 2055023002: Exclude more CSS properties for fullscreen video on Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/css/fullscreenAndroid.css

Issue 2055023002: Exclude more CSS properties for fullscreen video on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Android only. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/child/blink_platform_impl.cc ('k') | third_party/WebKit/Source/core/layout/LayoutThemeMobile.h » ('j') | third_party/WebKit/Source/core/layout/LayoutThemeMobile.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 video:-webkit-full-screen, audio:-webkit-full-screen {
	foolip 2016/06/21 16:59:36 Should it really apply to audio elements? They can Should it really apply to audio elements? They can never paint video frames :) sandersd (OOO until July 31) 2016/06/21 18:30:08 Done. (I did not change fullscreen.css to match th Show quoted text On 2016/06/21 16:59:36, Philip Jägenstedt wrote: > Should it really apply to audio elements? They can never paint video frames :) Done. (I did not change fullscreen.css to match though.)
	2 border: none !important;
	foolip 2016/06/21 16:59:36 This one ought to go away with the top layer rewri This one ought to go away with the top layer rewrite at least. Can you add a link to the bug and a short description of why this is needed? Also, isn't it needed when playing inline as well, or does it just never work for that case? sandersd (OOO until July 31) 2016/06/21 18:30:08 This is specific to fullscreen on Android, for inl Show quoted text On 2016/06/21 16:59:36, Philip Jägenstedt wrote: > This one ought to go away with the top layer rewrite at least. > > Can you add a link to the bug and a short description of why this is needed? > Also, isn't it needed when playing inline as well, or does it just never work > for that case? This is specific to fullscreen on Android, for inline video the compositing path is correct.
	3 background-image: none !important;

	4 opacity: 1 !important;

	5 -webkit-filter: none !important;
	foolip 2016/06/21 16:59:36 -webkit-filter is an alias for filter, are both ne -webkit-filter is an alias for filter, are both needed? sandersd (OOO until July 31) 2016/06/21 18:30:08 Then it'll have to be the -webkit-filter variant, Show quoted text On 2016/06/21 16:59:36, Philip Jägenstedt wrote: > -webkit-filter is an alias for filter, are both needed? Then it'll have to be the -webkit-filter variant, since this needs to be merge-able with M52.
	6 filter: none !important;

	7 border-radius: 0 !important;

	8 mix-blend-mode: normal !important;

	9 }

OLD	NEW