Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2054973002: Upstream: Enable proguard on WebApk.template.apk in release mode (Closed)

Created:
4 years, 6 months ago by pkotwicz
Modified:
4 years, 6 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream: Enable proguard on WebApk.template.apk in release mode BUG=609122 Committed: https://crrev.com/2c8b88ae551a1da6d9887626ca8729917fd9ae2f Cr-Commit-Position: refs/heads/master@{#399450}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/android/webapk/shell_apk/AndroidManifest.xml View 3 chunks +4 lines, -2 lines 2 comments Download
M chrome/android/webapk/shell_apk/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
pkotwicz
Xi can you please take a look? I used the "Chrome proguard file" instead of ...
4 years, 6 months ago (2016-06-09 20:51:38 UTC) #3
Xi Han
https://codereview.chromium.org/2054973002/diff/20001/chrome/android/webapk/shell_apk/AndroidManifest.xml File chrome/android/webapk/shell_apk/AndroidManifest.xml (right): https://codereview.chromium.org/2054973002/diff/20001/chrome/android/webapk/shell_apk/AndroidManifest.xml#newcode30 chrome/android/webapk/shell_apk/AndroidManifest.xml:30: <data android:scheme="https" android:host="{{ scope_url_host }}" android:pathPrefix="/"></data> Have you verified ...
4 years, 6 months ago (2016-06-10 18:54:33 UTC) #4
pkotwicz
https://codereview.chromium.org/2054973002/diff/20001/chrome/android/webapk/shell_apk/AndroidManifest.xml File chrome/android/webapk/shell_apk/AndroidManifest.xml (right): https://codereview.chromium.org/2054973002/diff/20001/chrome/android/webapk/shell_apk/AndroidManifest.xml#newcode30 chrome/android/webapk/shell_apk/AndroidManifest.xml:30: <data android:scheme="https" android:host="{{ scope_url_host }}" android:pathPrefix="/"></data> I have :)
4 years, 6 months ago (2016-06-10 20:16:00 UTC) #5
Xi Han
Cool, lgtm!
4 years, 6 months ago (2016-06-10 20:25:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054973002/20001
4 years, 6 months ago (2016-06-10 21:36:07 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/176204)
4 years, 6 months ago (2016-06-10 23:57:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054973002/20001
4 years, 6 months ago (2016-06-13 14:35:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-13 15:22:40 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 15:24:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c8b88ae551a1da6d9887626ca8729917fd9ae2f
Cr-Commit-Position: refs/heads/master@{#399450}

Powered by Google App Engine
This is Rietveld 408576698