Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 205493003: linux_aura: Fix PRIMARY selection in the content area. (Closed)

Created:
6 years, 9 months ago by Elliot Glaysher
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

linux_aura: Fix PRIMARY selection in the content area. When selecting any text in the content area, we put the entire text range on the PRIMARY clipboard instead of just the selected text. This patch copies what RWHVGtk does to RWHVAura. BUG=341105 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258336

Patch Set 1 #

Patch Set 2 : Fix style nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Elliot Glaysher
6 years, 9 months ago (2014-03-19 22:59:24 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 9 months ago (2014-03-19 23:24:14 UTC) #2
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 9 months ago (2014-03-20 00:27:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/205493003/2
6 years, 9 months ago (2014-03-20 00:29:21 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 03:21:44 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=284859
6 years, 9 months ago (2014-03-20 03:21:44 UTC) #6
Elliot Glaysher
6 years, 9 months ago (2014-03-20 17:53:25 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 manually as r258336 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698