Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 2054913002: hook up background task's "startProcessing" from Java to request_coordinator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.cc
diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc
index 3481218caf43d8f77796d78ebf46eb9522924a1b..9d3421ef8ac0afab6688040368edb8e82d2de6ac 100644
--- a/components/offline_pages/background/request_coordinator.cc
+++ b/components/offline_pages/background/request_coordinator.cc
@@ -69,6 +69,11 @@ void RequestCoordinator::AddRequestResultCallback(
}
void RequestCoordinator::RequestPicked(const SavePageRequest& request) {
+ Scheduler::TriggerCondition conditions;
+
+ // Inform the scheduler that we have an outstanding task.
dougarnett 2016/06/09 21:54:27 thought this comment wording was confusing - the s
Pete Williamson 2016/06/09 22:09:48 No, this is really about ensuring that the current
dougarnett 2016/06/09 22:27:05 Hmm, not sure I understand your response. Might be
Pete Williamson 2016/06/09 22:30:17 I was thinking that we might also get here via an
+ scheduler_->Schedule(conditions);
+
// Send the request on to the offliner.
SendRequestToOffliner(request);
}

Powered by Google App Engine
This is Rietveld 408576698